You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:25:35 UTC

[GitHub] [incubator-mxnet] Kh4L opened a new issue #18824: [RFC] Double dependency for ONNX

Kh4L opened a new issue #18824:
URL: https://github.com/apache/incubator-mxnet/issues/18824


   ## Description
   ONNX is integrated as a dependency of onnx_tensorrt, which is itself a dependency (3rd party) of MXNet.
   In parallel, ONNX is directly used by MXNet for its import and export functionalities.
   
   Updating onnx_tensorrt can break the ONNX import/export functionalities.
   
   This is not necessarily an issue, but it makes the ONNX dependency brittle.
   
   Opening this issue to track it and potentially find a better way to track the dependency.
   
   ## References
   - [Export ONNX C++](https://github.com/apache/incubator-mxnet/blob/master/src/operator/subgraph/tensorrt/nnvm_to_onnx-inl.h)
   - [Export/Import ONNX Python](https://github.com/apache/incubator-mxnet/tree/master/python/mxnet/contrib/onnx)
   - https://github.com/onnx/onnx-tensorrt 
   
   cc @ChaiBapchya 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on issue #18824: [RFC] Double dependency for ONNX

Posted by GitBox <gi...@apache.org>.
szha commented on issue #18824:
URL: https://github.com/apache/incubator-mxnet/issues/18824#issuecomment-666989953


   Can we drop onnx-tensorrt in favor of native tensorrt integration? It seems perfectly ok to run that outside of MXNet as it's more of an ONNX feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha edited a comment on issue #18824: [RFC] Double dependency for ONNX

Posted by GitBox <gi...@apache.org>.
szha edited a comment on issue #18824:
URL: https://github.com/apache/incubator-mxnet/issues/18824#issuecomment-666989953


   Can we drop onnx-tensorrt in favor of native tensorrt integration? It seems perfectly ok to run that outside of MXNet as it's more of an ONNX feature. It would be great to have some insights on what impact this simplification may have


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #18824: [RFC] Double dependency for ONNX

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #18824:
URL: https://github.com/apache/incubator-mxnet/issues/18824#issuecomment-665983516


   Thanks for creating the RFC. For readers to understand this issue better, could you substantiate with the PR example of how onnx_tensorrt updates can break the MX-ONNX import/export functionalities?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org