You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/23 04:59:29 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1651: feat: update menuicon
LiteSun opened a new pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
update meunicon
**Related issues**
fix/resolve #0001
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804683566
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804621787
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=h1) Report
> Merging [#1651](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=desc) (ff218eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **decrease** coverage by `22.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1651 +/- ##
===========================================
- Coverage 70.33% 47.84% -22.49%
===========================================
Files 134 47 -87
Lines 5737 3116 -2621
Branches 665 0 -665
===========================================
- Hits 4035 1491 -2544
+ Misses 1450 1340 -110
- Partials 252 285 +33
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `47.84% <ø> (?)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-36.12%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-31.93%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-26.09%)` | :arrow_down: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `65.95% <0.00%> (-25.54%)` | :arrow_down: |
| ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=footer). Last update [eecadb8...ff218eb](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804621787
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=h1) Report
> Merging [#1651](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=desc) (ff218eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **decrease** coverage by `8.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
- Coverage 70.33% 61.77% -8.56%
==========================================
Files 134 47 -87
Lines 5737 3116 -2621
Branches 665 0 -665
==========================================
- Hits 4035 1925 -2110
+ Misses 1450 878 -572
- Partials 252 313 +61
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `61.77% <ø> (+13.15%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `47.84% <ø> (?)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-26.09%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
| [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | `88.23% <0.00%> (-11.77%)` | :arrow_down: |
| ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=footer). Last update [eecadb8...ff218eb](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean merged pull request #1651: feat: update sidebar's menuicon
Posted by GitBox <gi...@apache.org>.
Jaycean merged pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804686080
just regenerated the icons, waiting for upload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#discussion_r599294963
##########
File path: web/src/helpers.tsx
##########
@@ -45,17 +46,17 @@ export const getMenuData = (): MenuDataItem[] => {
{
name: 'service',
path: '/service/list',
- icon: <IconFont name="iconconsumer" />,
+ icon: <IconFont name="iconservice" />,
},
{
name: 'consumer',
path: '/consumer/list',
- icon: <IconFont name="iconconsumer" />,
+ icon: <IconFont name="iconconsumer1" />,
Review comment:
it seems that `iconconsumer` is used, how about remove the old `iconconsumer`, and rename the new one `iconconsumer1` to `iconconsumer`, that would be more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1651: feat: update menuicon
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1651:
URL: https://github.com/apache/apisix-dashboard/pull/1651#discussion_r599330396
##########
File path: web/src/helpers.tsx
##########
@@ -45,17 +46,17 @@ export const getMenuData = (): MenuDataItem[] => {
{
name: 'service',
path: '/service/list',
- icon: <IconFont name="iconconsumer" />,
+ icon: <IconFont name="iconservice" />,
},
{
name: 'consumer',
path: '/consumer/list',
- icon: <IconFont name="iconconsumer" />,
+ icon: <IconFont name="iconconsumer1" />,
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org