You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/05 13:08:52 UTC

[GitHub] [incubator-echarts] bogdanhoancea420 opened a new issue #12759: Can't format the "detail" object for a gauge series

bogdanhoancea420 opened a new issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759


   ### What problem does this feature solve?
   This option exists in the docs (https://echarts.apache.org/en/option.html#series-gauge.detail.formatter), but the formatter doesn't exist for the "detail" object of the gauge series (echarts v4.8.0). I would like to format the value as a percentage.
   
   ### What does the proposed API look like?
   It should work exactly like in the editor. The "detail" object of a series should have a "formatter" property.
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] wf123537200 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
wf123537200 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-639950466


   It seems that it is just a grammar test error, Is it the drawing result is correct?
   Can you give examples or screenshots?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640307982


   It's indeed for missing `formatter` option in `series.gauge`, maybe you need to add it manually. 
   After all, we can see that this repository is maintained at a long period interval and many of the types have been changed.
   ECharts team is already developing with TypeScript under [`next`](https://github.com/apache/incubator-echarts/tree/next) branch, in the near future, `ECharts@types` will be not necessary any more.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-639469996


   ![image](https://user-images.githubusercontent.com/66477195/83879839-93573b80-a73e-11ea-987f-31bf9e522b98.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart removed a comment on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart removed a comment on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640305106


   That seems to be a bit weird.
   I saw it exists in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/echarts/options/series/gauge.d.ts#L2026


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640025418


   As document says, [series-gauge.detail.formatter](https://echarts.apache.org/en/option.html#series-gauge.detail.formatter) should return a function or a number, so is it better to set return type as `Function | number`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640201748


   yes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-645370914


   > A simple fix would be changing the return value to `as any`. You may also make a pull request to [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/echarts), or wait for it to be fixed in next branch.
   
   This is indeed how I temporarily fixed it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart edited a comment on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640025418


   As document says, [series-gauge.detail.formatter](https://echarts.apache.org/en/option.html#series-gauge.detail.formatter) should return a function or a string, so is it better to set return type as `Function | string`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640305106


   That seems to be a bit weird.
   I saw it exists in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/echarts/options/series/gauge.d.ts#L2026


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-639469477


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640013700


   If I change the return type from SeriesGauge to "any", the drawing result is correct. However, that defeats the point of using TS


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640150945


   Could you tell me what library you are using, is it  [ECharts@types](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/echarts) ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640094103


   I'm not sure if my problem is understood. What I need as return type is a "series-gauge" object. that object contains object detail which, in the docs, contains "formatter" which is a function or a string. However, the Node JS interface "series-gauge.detail" does **not** contain the "formatter" property. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] bogdanhoancea420 edited a comment on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
bogdanhoancea420 edited a comment on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640094103


   I'm not sure if my problem is understood. What I need as return type is a "series-gauge" object. that object contains object "detail" which, in the docs, contains object "formatter" which is either a function or a string. However, the Node JS interface "series-gauge.detail" does **not** contain the "formatter" property. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] Ovilia commented on issue #12759: Can't format the "detail" object for a gauge series

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12759:
URL: https://github.com/apache/incubator-echarts/issues/12759#issuecomment-640326131


   A simple fix would be changing the return value to `as any`. You may also make a pull request to [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/echarts), or wait for it to be fixed in next branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org