Re: [PR] feat: Make GenericDistinctBuffer generic over both Hashable and native types [datafusion]

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on code in PR #18763:
URL: https://github.com/apache/datafusion/pull/18763#discussion_r2658717474


##########
benchmarks/src/bin/dfbench.rs:
##########
@@ -34,17 +34,20 @@ static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
 static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
 
 use datafusion_benchmarks::{
-    cancellation, clickbench, h2o, hj, imdb, nlj, smj, sort_tpch, tpcds, tpch,
+    cancellation, clickbench, distinct, h2o, hj, imdb, nlj, quantiles, smj, sort_tpch,
+    tpcds, tpch,
 };
 
 #[derive(Debug, StructOpt)]
 #[structopt(about = "benchmark command")]
 enum Options {
     Cancellation(cancellation::RunOpt),
     Clickbench(clickbench::RunOpt),
+    Distinct(distinct::RunOpt),

Review Comment:
   I don't think we want to add benchmarks here; they would be more appropriate as microbenchmarks here: https://github.com/apache/datafusion/tree/main/datafusion/functions-aggregate/benches



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org