[GitHub] [beam] saavannanavati commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

[GitBox <gi...@apache.org>]

saavannanavati commented on a change in pull request #12242:
URL: https://github.com/apache/beam/pull/12242#discussion_r468089367



##########
File path: sdks/python/apache_beam/testing/load_tests/runtime_type_check_off_test_py3.py
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+For more information, see documentation in the parent class.
+
+Example test run:
+
+python -m apache_beam.testing.load_tests.runtime_type_check_off_test_py3 \
+    --test-pipeline-options="
+    --project=apache-beam-testing
+    --region=us-centrall
+    --publish_to_big_query=true
+    --metrics_dataset=python_load_tests
+    --metrics_table=gbk
+    --nested_typehint=0
+    --fanout=200
+    --num_records=1000
+    --input_options='{
+    \"num_records\": 0,
+    \"key_size\": 0,
+    \"value_size\": 0
+    }'"
+"""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import logging
+
+from apache_beam.testing.load_tests.base_runtime_type_check_test_py3 import \
+    BaseRunTimeTypeCheckTest
+
+
+class RunTimeTypeCheckOffTest(BaseRunTimeTypeCheckTest):
+  def __init__(self):
+    self.runtime_type_check = False

Review comment:
       We looked into this but all flags that are passed to the test are parsed after the LoadTest has been initialized, and it's in this initialization process that the pipeline options are defined and used. We tried parsing `runtime_type_check` before the Pipeline was initialized in the constructor so we could pass it through as an option, but the method of parsing used by LoadTest is a non-static class function that we can't call until the constructor has finished.
   
   Is there a workaround?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org