[jira] [Commented] (MAPREDUCE-3990) MRBench allows Long-sized input-lines value but parses CLI argument as an Integer

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225875#comment-13225875 ] 

Hadoop QA commented on MAPREDUCE-3990:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517679/MAPREDUCE-3990.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2022//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2022//console

This message is automatically generated.
                
> MRBench allows Long-sized input-lines value but parses CLI argument as an Integer
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3990
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3990
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: MAPREDUCE-3990.patch
>
>
> MRBench has the following method:
> {code}
> public void generateTextFile(FileSystem fs, Path inputFile, long numLines, Order sortOrder) { ... }
> {code}
> The method is already set to accept a long datatype for numLines, for generating very large amount of data.
> However, in {{MRBench#run(...)}}, the inputLines CLI parameter is parsed via an Integer.parseInt, causing numbers passed > Integer.MAX_VALUE to throw NumberFormatExceptions as a result.
> The parsing should be Long.parseLong and the inputLines datatype should be switched to the same type as passed to the method (long).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira