You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/10 20:30:40 UTC
[GitHub] [incubator-tvm] t-vi opened a new pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
t-vi opened a new pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447
This is a ROCm followup for #6347 bringing the code that was moved from src/target/llvm/codegen_amdgpu.cc to src/target/target_kind.cc closer to the old mechanism for compute arch autodetection.
@junrushao1994 @masahi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690898056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] t-vi commented on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
t-vi commented on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690731565
@junrushao1994 Yeah, and I'll admit that I wouldn't have spotted it without trying to run it on the hardware that is particular about it...
I actually hope that we might be able to drop the code-object thing in due time, but so 3.5 (which changed this) was released in June and I'm not sure how long we would need to give people to upgrade ROCm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690898056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690898056
Thanks @t-vi @junrushao1994 @tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 edited a comment on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
junrushao1994 edited a comment on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690711679
I see. So there are actually two version, one is ApiVersion, which is used to decide whether to add "-code-object-v3" into mattr; Another is GcnArch, which is used to decode "mcpu". Thank you for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6447: ROCm: use GcnArch for mcpu and ApiVersion to select code object version
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6447:
URL: https://github.com/apache/incubator-tvm/pull/6447#issuecomment-690711679
I see. So there are actually two version, one ApiVersion, which is used to decide whether to add "-code-object-v3" into mattr; Another is GcnArch, which is used to decode "mcpu". Thank you for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org