You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by as...@apache.org on 2026/05/28 05:03:51 UTC
(ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
This is an automated email from the ASF dual-hosted git repository.
ashishvijaywargiya pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5b32998eb3 Fixed a typo from the following commit:
5b32998eb3 is described below
commit 5b32998eb38f0ea77e306384038273b6a9161fda
Author: Ashish Vijaywargiya <as...@apache.org>
AuthorDate: Thu May 28 10:30:23 2026 +0530
Fixed a typo from the following commit:
https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
---
.../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
index c5cacbfd8d..bc7c41703d 100644
--- a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
+++ b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
@@ -496,7 +496,7 @@ public class ObjectTypeTests {
System.setProperty("testBigDecimal", "bypassLocaleChange");
simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String", new BigDecimal("12345.67"),
new String[] {"String", "java.lang.String"}, null, LOCALE_DATA, "12,345.67");
- System.clearProperty("testBigDecima");
+ System.clearProperty("testBigDecimal");
simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml,
new String[] {"BigDecimal", "java.math.BigDecimal"}, new BigDecimal("781.25"));
simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double", dcml,
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacques Le Roux via dev <de...@ofbiz.apache.org>.
Ha, it's already fixed by Jacopo :)
Le 28/05/2026 à 10:40, Jacques Le Roux via dev a écrit :
> Hi,
>
> If that can help the error is in SecurityUtilTest.java[98]
> ie SecurityUtilTest::checkOfbizFileAllowListAcceptsFileUnderSymlinkedAllowedDir
>
> I did not find any other use of testBigDecimal property than in ObjectTypeTests::testBigDecimal
>
> Sorry, I have no time to get further
>
> HTH
>
> Jacques
>
> Le 28/05/2026 à 09:13, Jacopo Cappellato a écrit :
>> Hi Ashish,
>>
>> After you have fixed the typo, one test is failing. I didn't investigate
>> it, but I suspect that the "testBigDecimal" property is used elsewhere and
>> unsetting it makes the test fail. It was working before because, thanks to
>> the typo, the property was not unset. The two errors were cancelling out
>> each other :-(
>>
>> Jacopo
>>
>> On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> ashishvijaywargiya pushed a commit to branch trunk
>>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/trunk by this push:
>>> new 5b32998eb3 Fixed a typo from the following commit:
>>> 5b32998eb3 is described below
>>>
>>> commit 5b32998eb38f0ea77e306384038273b6a9161fda
>>> Author: Ashish Vijaywargiya <as...@apache.org>
>>> AuthorDate: Thu May 28 10:30:23 2026 +0530
>>>
>>> Fixed a typo from the following commit:
>>>
>>>
>>> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
>>> ---
>>> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java |
>>> 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>>> index c5cacbfd8d..bc7c41703d 100644
>>> ---
>>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>>> +++
>>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>>> @@ -496,7 +496,7 @@ public class ObjectTypeTests {
>>> System.setProperty("testBigDecimal", "bypassLocaleChange");
>>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
>>> new BigDecimal("12345.67"),
>>> new String[] {"String", "java.lang.String"}, null,
>>> LOCALE_DATA, "12,345.67");
>>> - System.clearProperty("testBigDecima");
>>> + System.clearProperty("testBigDecimal");
>>>
>>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml,
>>> new String[] {"BigDecimal", "java.math.BigDecimal"}, new
>>> BigDecimal("781.25"));
>>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
>>> dcml,
>>>
>>>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacques Le Roux via dev <de...@ofbiz.apache.org>.
Hi,
If that can help the error is in SecurityUtilTest.java[98]
ie SecurityUtilTest::checkOfbizFileAllowListAcceptsFileUnderSymlinkedAllowedDir
I did not find any other use of testBigDecimal property than in ObjectTypeTests::testBigDecimal
Sorry, I have no time to get further
HTH
Jacques
Le 28/05/2026 à 09:13, Jacopo Cappellato a écrit :
> Hi Ashish,
>
> After you have fixed the typo, one test is failing. I didn't investigate
> it, but I suspect that the "testBigDecimal" property is used elsewhere and
> unsetting it makes the test fail. It was working before because, thanks to
> the typo, the property was not unset. The two errors were cancelling out
> each other :-(
>
> Jacopo
>
> On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> ashishvijaywargiya pushed a commit to branch trunk
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>
>>
>> The following commit(s) were added to refs/heads/trunk by this push:
>> new 5b32998eb3 Fixed a typo from the following commit:
>> 5b32998eb3 is described below
>>
>> commit 5b32998eb38f0ea77e306384038273b6a9161fda
>> Author: Ashish Vijaywargiya <as...@apache.org>
>> AuthorDate: Thu May 28 10:30:23 2026 +0530
>>
>> Fixed a typo from the following commit:
>>
>>
>> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
>> ---
>> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java |
>> 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> index c5cacbfd8d..bc7c41703d 100644
>> ---
>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> +++
>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> @@ -496,7 +496,7 @@ public class ObjectTypeTests {
>> System.setProperty("testBigDecimal", "bypassLocaleChange");
>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
>> new BigDecimal("12345.67"),
>> new String[] {"String", "java.lang.String"}, null,
>> LOCALE_DATA, "12,345.67");
>> - System.clearProperty("testBigDecima");
>> + System.clearProperty("testBigDecimal");
>>
>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml,
>> new String[] {"BigDecimal", "java.math.BigDecimal"}, new
>> BigDecimal("781.25"));
>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
>> dcml,
>>
>>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacopo Cappellato <ja...@gmail.com>.
No need to apologize! Thank you.
The test should pass now after I merged
https://github.com/apache/ofbiz-framework/pull/1292
I am monitoring the GitHub workflows and BuildBot run.
Jacopo
On Thu, May 28, 2026 at 11:01 AM Ashish Vijaywargiya <as...@apache.org>
wrote:
> Hello Jacopo,
>
> Going forward I will strictly follow the shared practices/workflow for all
> my commits in the Apache OFBiz project.
>
> Please accept sincere apologies from my side.
>
> I have been bypassing this practice(directly committing in ofbiz
> repository) for quite some time for minor fixes only but now and onwards,
> first of all I will create a PR and then wait for CI/CD workflow to run and
> then merge only after all checks have passed.
>
> Thanks,
> Ashish Vijaywargiya
>
> On Thu, 28 May 2026 at 13:35, Jacopo Cappellato <
> jacopo.cappellato@gmail.com>
> wrote:
>
> > Ashish, all,
> >
> > My advice is to refrain from pushing commits directly to the OFBiz
> > repository and instead always submit a pull request, wait for the CI/CD
> > workflows to run, and merge only after all checks have passed.
> >
> > By following the pull request workflow, this issue would not have
> occurred,
> > even if you did not run the tests locally (which is always recommended
> > before pushing changes anyway).
> >
> > Regards,
> > Jacopo
> >
> > On Thu, May 28, 2026 at 9:47 AM Jacopo Cappellato <
> > jacopo.cappellato@gmail.com> wrote:
> >
> > > Ashish,
> > >
> > > I am pushing a fix now.
> > >
> > > Jacopo
> > >
> > > On Thu, May 28, 2026 at 9:42 AM Ashish Vijaywargiya <ashish@apache.org
> >
> > > wrote:
> > >
> > >> Hello Jacopo,
> > >>
> > >> Thank you. I am looking into the failed test.
> > >>
> > >> --
> > >> Thanks,
> > >> Ashish Vijaywargiya
> > >>
> > >>
> > >> On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <
> > >> jacopo.cappellato@gmail.com>
> > >> wrote:
> > >>
> > >> > Hi Ashish,
> > >> >
> > >> > After you have fixed the typo, one test is failing. I didn't
> > investigate
> > >> > it, but I suspect that the "testBigDecimal" property is used
> elsewhere
> > >> and
> > >> > unsetting it makes the test fail. It was working before because,
> > thanks
> > >> to
> > >> > the typo, the property was not unset. The two errors were cancelling
> > out
> > >> > each other :-(
> > >> >
> > >> > Jacopo
> > >> >
> > >> > On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
> > >> >
> > >> > > This is an automated email from the ASF dual-hosted git
> repository.
> > >> > >
> > >> > > ashishvijaywargiya pushed a commit to branch trunk
> > >> > > in repository
> > https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> > >> > >
> > >> > >
> > >> > > The following commit(s) were added to refs/heads/trunk by this
> push:
> > >> > > new 5b32998eb3 Fixed a typo from the following commit:
> > >> > > 5b32998eb3 is described below
> > >> > >
> > >> > > commit 5b32998eb38f0ea77e306384038273b6a9161fda
> > >> > > Author: Ashish Vijaywargiya <as...@apache.org>
> > >> > > AuthorDate: Thu May 28 10:30:23 2026 +0530
> > >> > >
> > >> > > Fixed a typo from the following commit:
> > >> > >
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
> > >> > > ---
> > >> > >
> > >> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >> > |
> > >> > > 2 +-
> > >> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> > >
> > >> > > diff --git
> > >> > >
> > >> >
> > >>
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >> > >
> > >> >
> > >>
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >> > > index c5cacbfd8d..bc7c41703d 100644
> > >> > > ---
> > >> > >
> > >> >
> > >>
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >> > > +++
> > >> > >
> > >> >
> > >>
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >> > > @@ -496,7 +496,7 @@ public class ObjectTypeTests {
> > >> > > System.setProperty("testBigDecimal",
> "bypassLocaleChange");
> > >> > >
> > >> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
> > >> > > new BigDecimal("12345.67"),
> > >> > > new String[] {"String", "java.lang.String"},
> null,
> > >> > > LOCALE_DATA, "12,345.67");
> > >> > > - System.clearProperty("testBigDecima");
> > >> > > + System.clearProperty("testBigDecimal");
> > >> > >
> > >> > >
> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal",
> > >> dcml,
> > >> > > new String[] {"BigDecimal",
> > "java.math.BigDecimal"},
> > >> new
> > >> > > BigDecimal("781.25"));
> > >> > >
> > >> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
> > >> > > dcml,
> > >> > >
> > >> > >
> > >> >
> > >>
> > >
> >
>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Ashish Vijaywargiya <as...@apache.org>.
Hello Jacopo,
Going forward I will strictly follow the shared practices/workflow for all
my commits in the Apache OFBiz project.
Please accept sincere apologies from my side.
I have been bypassing this practice(directly committing in ofbiz
repository) for quite some time for minor fixes only but now and onwards,
first of all I will create a PR and then wait for CI/CD workflow to run and
then merge only after all checks have passed.
Thanks,
Ashish Vijaywargiya
On Thu, 28 May 2026 at 13:35, Jacopo Cappellato <ja...@gmail.com>
wrote:
> Ashish, all,
>
> My advice is to refrain from pushing commits directly to the OFBiz
> repository and instead always submit a pull request, wait for the CI/CD
> workflows to run, and merge only after all checks have passed.
>
> By following the pull request workflow, this issue would not have occurred,
> even if you did not run the tests locally (which is always recommended
> before pushing changes anyway).
>
> Regards,
> Jacopo
>
> On Thu, May 28, 2026 at 9:47 AM Jacopo Cappellato <
> jacopo.cappellato@gmail.com> wrote:
>
> > Ashish,
> >
> > I am pushing a fix now.
> >
> > Jacopo
> >
> > On Thu, May 28, 2026 at 9:42 AM Ashish Vijaywargiya <as...@apache.org>
> > wrote:
> >
> >> Hello Jacopo,
> >>
> >> Thank you. I am looking into the failed test.
> >>
> >> --
> >> Thanks,
> >> Ashish Vijaywargiya
> >>
> >>
> >> On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <
> >> jacopo.cappellato@gmail.com>
> >> wrote:
> >>
> >> > Hi Ashish,
> >> >
> >> > After you have fixed the typo, one test is failing. I didn't
> investigate
> >> > it, but I suspect that the "testBigDecimal" property is used elsewhere
> >> and
> >> > unsetting it makes the test fail. It was working before because,
> thanks
> >> to
> >> > the typo, the property was not unset. The two errors were cancelling
> out
> >> > each other :-(
> >> >
> >> > Jacopo
> >> >
> >> > On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
> >> >
> >> > > This is an automated email from the ASF dual-hosted git repository.
> >> > >
> >> > > ashishvijaywargiya pushed a commit to branch trunk
> >> > > in repository
> https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >> > >
> >> > >
> >> > > The following commit(s) were added to refs/heads/trunk by this push:
> >> > > new 5b32998eb3 Fixed a typo from the following commit:
> >> > > 5b32998eb3 is described below
> >> > >
> >> > > commit 5b32998eb38f0ea77e306384038273b6a9161fda
> >> > > Author: Ashish Vijaywargiya <as...@apache.org>
> >> > > AuthorDate: Thu May 28 10:30:23 2026 +0530
> >> > >
> >> > > Fixed a typo from the following commit:
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
> >> > > ---
> >> > >
> >> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >> > |
> >> > > 2 +-
> >> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> > >
> >> > > diff --git
> >> > >
> >> >
> >>
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >> > >
> >> >
> >>
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >> > > index c5cacbfd8d..bc7c41703d 100644
> >> > > ---
> >> > >
> >> >
> >>
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >> > > +++
> >> > >
> >> >
> >>
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >> > > @@ -496,7 +496,7 @@ public class ObjectTypeTests {
> >> > > System.setProperty("testBigDecimal", "bypassLocaleChange");
> >> > >
> >> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
> >> > > new BigDecimal("12345.67"),
> >> > > new String[] {"String", "java.lang.String"}, null,
> >> > > LOCALE_DATA, "12,345.67");
> >> > > - System.clearProperty("testBigDecima");
> >> > > + System.clearProperty("testBigDecimal");
> >> > >
> >> > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal",
> >> dcml,
> >> > > new String[] {"BigDecimal",
> "java.math.BigDecimal"},
> >> new
> >> > > BigDecimal("781.25"));
> >> > >
> >> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
> >> > > dcml,
> >> > >
> >> > >
> >> >
> >>
> >
>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacopo Cappellato <ja...@gmail.com>.
Ashish, all,
My advice is to refrain from pushing commits directly to the OFBiz
repository and instead always submit a pull request, wait for the CI/CD
workflows to run, and merge only after all checks have passed.
By following the pull request workflow, this issue would not have occurred,
even if you did not run the tests locally (which is always recommended
before pushing changes anyway).
Regards,
Jacopo
On Thu, May 28, 2026 at 9:47 AM Jacopo Cappellato <
jacopo.cappellato@gmail.com> wrote:
> Ashish,
>
> I am pushing a fix now.
>
> Jacopo
>
> On Thu, May 28, 2026 at 9:42 AM Ashish Vijaywargiya <as...@apache.org>
> wrote:
>
>> Hello Jacopo,
>>
>> Thank you. I am looking into the failed test.
>>
>> --
>> Thanks,
>> Ashish Vijaywargiya
>>
>>
>> On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <
>> jacopo.cappellato@gmail.com>
>> wrote:
>>
>> > Hi Ashish,
>> >
>> > After you have fixed the typo, one test is failing. I didn't investigate
>> > it, but I suspect that the "testBigDecimal" property is used elsewhere
>> and
>> > unsetting it makes the test fail. It was working before because, thanks
>> to
>> > the typo, the property was not unset. The two errors were cancelling out
>> > each other :-(
>> >
>> > Jacopo
>> >
>> > On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
>> >
>> > > This is an automated email from the ASF dual-hosted git repository.
>> > >
>> > > ashishvijaywargiya pushed a commit to branch trunk
>> > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>> > >
>> > >
>> > > The following commit(s) were added to refs/heads/trunk by this push:
>> > > new 5b32998eb3 Fixed a typo from the following commit:
>> > > 5b32998eb3 is described below
>> > >
>> > > commit 5b32998eb38f0ea77e306384038273b6a9161fda
>> > > Author: Ashish Vijaywargiya <as...@apache.org>
>> > > AuthorDate: Thu May 28 10:30:23 2026 +0530
>> > >
>> > > Fixed a typo from the following commit:
>> > >
>> > >
>> > >
>> >
>> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
>> > > ---
>> > >
>> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> > |
>> > > 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git
>> > >
>> >
>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> > >
>> >
>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> > > index c5cacbfd8d..bc7c41703d 100644
>> > > ---
>> > >
>> >
>> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> > > +++
>> > >
>> >
>> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
>> > > @@ -496,7 +496,7 @@ public class ObjectTypeTests {
>> > > System.setProperty("testBigDecimal", "bypassLocaleChange");
>> > >
>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
>> > > new BigDecimal("12345.67"),
>> > > new String[] {"String", "java.lang.String"}, null,
>> > > LOCALE_DATA, "12,345.67");
>> > > - System.clearProperty("testBigDecima");
>> > > + System.clearProperty("testBigDecimal");
>> > >
>> > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal",
>> dcml,
>> > > new String[] {"BigDecimal", "java.math.BigDecimal"},
>> new
>> > > BigDecimal("781.25"));
>> > >
>> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
>> > > dcml,
>> > >
>> > >
>> >
>>
>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacopo Cappellato <ja...@gmail.com>.
Ashish,
I am pushing a fix now.
Jacopo
On Thu, May 28, 2026 at 9:42 AM Ashish Vijaywargiya <as...@apache.org>
wrote:
> Hello Jacopo,
>
> Thank you. I am looking into the failed test.
>
> --
> Thanks,
> Ashish Vijaywargiya
>
>
> On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <
> jacopo.cappellato@gmail.com>
> wrote:
>
> > Hi Ashish,
> >
> > After you have fixed the typo, one test is failing. I didn't investigate
> > it, but I suspect that the "testBigDecimal" property is used elsewhere
> and
> > unsetting it makes the test fail. It was working before because, thanks
> to
> > the typo, the property was not unset. The two errors were cancelling out
> > each other :-(
> >
> > Jacopo
> >
> > On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > ashishvijaywargiya pushed a commit to branch trunk
> > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/trunk by this push:
> > > new 5b32998eb3 Fixed a typo from the following commit:
> > > 5b32998eb3 is described below
> > >
> > > commit 5b32998eb38f0ea77e306384038273b6a9161fda
> > > Author: Ashish Vijaywargiya <as...@apache.org>
> > > AuthorDate: Thu May 28 10:30:23 2026 +0530
> > >
> > > Fixed a typo from the following commit:
> > >
> > >
> > >
> >
> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
> > > ---
> > > .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > |
> > > 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > >
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > >
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > > index c5cacbfd8d..bc7c41703d 100644
> > > ---
> > >
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > > +++
> > >
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > > @@ -496,7 +496,7 @@ public class ObjectTypeTests {
> > > System.setProperty("testBigDecimal", "bypassLocaleChange");
> > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
> > > new BigDecimal("12345.67"),
> > > new String[] {"String", "java.lang.String"}, null,
> > > LOCALE_DATA, "12,345.67");
> > > - System.clearProperty("testBigDecima");
> > > + System.clearProperty("testBigDecimal");
> > >
> > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal",
> dcml,
> > > new String[] {"BigDecimal", "java.math.BigDecimal"},
> new
> > > BigDecimal("781.25"));
> > > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
> > > dcml,
> > >
> > >
> >
>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Ashish Vijaywargiya <as...@apache.org>.
Hello Jacopo,
Thank you. I am looking into the failed test.
--
Thanks,
Ashish Vijaywargiya
On Thu, 28 May 2026 at 12:44, Jacopo Cappellato <ja...@gmail.com>
wrote:
> Hi Ashish,
>
> After you have fixed the typo, one test is failing. I didn't investigate
> it, but I suspect that the "testBigDecimal" property is used elsewhere and
> unsetting it makes the test fail. It was working before because, thanks to
> the typo, the property was not unset. The two errors were cancelling out
> each other :-(
>
> Jacopo
>
> On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ashishvijaywargiya pushed a commit to branch trunk
> > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >
> >
> > The following commit(s) were added to refs/heads/trunk by this push:
> > new 5b32998eb3 Fixed a typo from the following commit:
> > 5b32998eb3 is described below
> >
> > commit 5b32998eb38f0ea77e306384038273b6a9161fda
> > Author: Ashish Vijaywargiya <as...@apache.org>
> > AuthorDate: Thu May 28 10:30:23 2026 +0530
> >
> > Fixed a typo from the following commit:
> >
> >
> >
> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
> > ---
> > .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> |
> > 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > index c5cacbfd8d..bc7c41703d 100644
> > ---
> >
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > +++
> >
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> > @@ -496,7 +496,7 @@ public class ObjectTypeTests {
> > System.setProperty("testBigDecimal", "bypassLocaleChange");
> > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
> > new BigDecimal("12345.67"),
> > new String[] {"String", "java.lang.String"}, null,
> > LOCALE_DATA, "12,345.67");
> > - System.clearProperty("testBigDecima");
> > + System.clearProperty("testBigDecimal");
> >
> > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml,
> > new String[] {"BigDecimal", "java.math.BigDecimal"}, new
> > BigDecimal("781.25"));
> > simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
> > dcml,
> >
> >
>
Re: (ofbiz-framework) branch trunk updated: Fixed a typo from the following commit:
Posted by Jacopo Cappellato <ja...@gmail.com>.
Hi Ashish,
After you have fixed the typo, one test is failing. I didn't investigate
it, but I suspect that the "testBigDecimal" property is used elsewhere and
unsetting it makes the test fail. It was working before because, thanks to
the typo, the property was not unset. The two errors were cancelling out
each other :-(
Jacopo
On Thu, May 28, 2026 at 7:04 AM <as...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> ashishvijaywargiya pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
> new 5b32998eb3 Fixed a typo from the following commit:
> 5b32998eb3 is described below
>
> commit 5b32998eb38f0ea77e306384038273b6a9161fda
> Author: Ashish Vijaywargiya <as...@apache.org>
> AuthorDate: Thu May 28 10:30:23 2026 +0530
>
> Fixed a typo from the following commit:
>
>
> https://github.com/apache/ofbiz-framework/commit/d6993ecabb311b2cf59f343072d78b5db666e815
> ---
> .../base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java |
> 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> index c5cacbfd8d..bc7c41703d 100644
> ---
> a/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> +++
> b/framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
> @@ -496,7 +496,7 @@ public class ObjectTypeTests {
> System.setProperty("testBigDecimal", "bypassLocaleChange");
> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->String",
> new BigDecimal("12345.67"),
> new String[] {"String", "java.lang.String"}, null,
> LOCALE_DATA, "12,345.67");
> - System.clearProperty("testBigDecima");
> + System.clearProperty("testBigDecimal");
>
> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->BigDecimal", dcml,
> new String[] {"BigDecimal", "java.math.BigDecimal"}, new
> BigDecimal("781.25"));
> simpleTypeOrObjectConvertTestSingleMulti("BigDecimal->Double",
> dcml,
>
>