You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2014/02/05 23:50:33 UTC

Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/
-----------------------------------------------------------

Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.


Repository: sentry


Description
-------

A few notes:
- We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
- SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
- There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?


Diffs
-----

  pom.xml 7db0088 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java PRE-CREATION 
  sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 

Diff: https://reviews.apache.org/r/17760/diff/


Testing
-------

Ran the solr e2e tests, haven't run the hive tests.


Thanks,

Gregory Chanan

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review33739
-----------------------------------------------------------

Ship it!


Ship It!

- Vamsee Yarlagadda


On Feb. 5, 2014, 10:50 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:50 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7db0088 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java PRE-CREATION 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review35583
-----------------------------------------------------------

Ship it!


Ship It!

- Vamsee Yarlagadda


On Feb. 26, 2014, 11:47 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 11:47 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fdfb72 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java 865fd10 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java ace0d0f 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java aaca7b4 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Brock Noland <br...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review35690
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Feb. 26, 2014, 11:47 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 11:47 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fdfb72 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java 865fd10 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java ace0d0f 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java aaca7b4 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Gregory Chanan <gc...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 11:47 p.m.)

Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.

Changes
-------

Updated for Vamsee's comments.

Repository: sentry

Description
-------

A few notes:
- We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work. We can move from the SNAPSHOT version when 4.7 is released.
- SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
- There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants. I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?). For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues. Maybe we should add all the dependent hadoop jars to the dependency management section? Any maven expert have a better idea?

Diffs (updated)
-----

pom.xml 7fdfb72
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java 865fd10
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java ace0d0f
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java aaca7b4
sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc

Diff: https://reviews.apache.org/r/17760/diff/

Testing
-------

Ran the solr e2e tests, haven't run the hive tests.

Thanks,

Gregory Chanan

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review35579
-----------------------------------------------------------



sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java
<https://reviews.apache.org/r/17760/#comment66206>

    nit. Typo "versoin" -> "version"


- Vamsee Yarlagadda


On Feb. 26, 2014, 11:22 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 11:22 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fdfb72 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java 865fd10 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java ace0d0f 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java aaca7b4 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Gregory Chanan <gc...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 11:22 p.m.)


Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.


Changes
-------

Small updates:
- Now that solr 4.7 has been released, depend on that rather than the SNAPSHOT version
- Because SOLR-5771 is not in solr 4.7, we need to add ALLOW_SSL = false to each test to get them to pass.


Repository: sentry


Description
-------

A few notes:
- We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
- SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
- There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?


Diffs (updated)
-----

  pom.xml 7fdfb72 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java 865fd10 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java ace0d0f 
  sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java aaca7b4 
  sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 

Diff: https://reviews.apache.org/r/17760/diff/


Testing
-------

Ran the solr e2e tests, haven't run the hive tests.


Thanks,

Gregory Chanan

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review33965
-----------------------------------------------------------

Ship it!


Ship It!

- Vamsee Yarlagadda


On Feb. 7, 2014, 8:58 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 8:58 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7db0088 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Gregory Chanan <gc...@cloudera.com>.

(Updated Feb. 7, 2014, 8:58 p.m.)

Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.

Changes
-------

SOLR-5682 was committed, so this gets rid of SecureSentryInfoHandler.

Repository: sentry

Description
-------

Diffs (updated)
-----

pom.xml 7db0088
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba
sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc

Diff: https://reviews.apache.org/r/17760/diff/

Testing
-------

Ran the solr e2e tests, haven't run the hive tests.

Thanks,

Gregory Chanan

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Gregory Chanan <gc...@cloudera.com>.


> On Feb. 5, 2014, 11:20 p.m., Vamsee Yarlagadda wrote:
> > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java, line 39
> > <https://reviews.apache.org/r/17760/diff/1/?file=470379#file470379line39>
> >
> >     Any particular reason for adding this class? As far as i understand, we only need this class if we are testing InfoHandler functions through Sentry, which we are currently not.
> >     
> >     To get a sense of completeness, it would make sense to add this custom class. But, at some point we need to remove it. Can we just have FIXME comment & Jira in solr-no-core.xml that we need to add SecureInfoHandler when SOLR-5682 is committed?

My thought, as you alluded to, was completeness.  If we advertise that we have support for upstream solr and people try it and it doesn't actually work for some (not uncommon) cases, they may be disappointed.  It also unblocks us if we want to add InfoHandler tests.  Plus, it's really easy to remove in the future.


- Gregory


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review33734
-----------------------------------------------------------


On Feb. 5, 2014, 10:50 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:50 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7db0088 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java PRE-CREATION 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 17760: SENTRY-106: Make solr testing work against apache 4.7 version

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17760/#review33734
-----------------------------------------------------------



sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java
<https://reviews.apache.org/r/17760/#comment63365>

    Any particular reason for adding this class? As far as i understand, we only need this class if we are testing InfoHandler functions through Sentry, which we are currently not.
    
    To get a sense of completeness, it would make sense to add this custom class. But, at some point we need to remove it. Can we just have FIXME comment & Jira in solr-no-core.xml that we need to add SecureInfoHandler when SOLR-5682 is committed? 


- Vamsee Yarlagadda


On Feb. 5, 2014, 10:50 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17760/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:50 p.m.)
> 
> 
> Review request for sentry, Brock Noland, Shreepadma Venugopalan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> A few notes:
> - We require solr version 4.7-SNAPSHOT currently because it has SOLR-5556, which is required to make this work.  We can move from the SNAPSHOT version when 4.7 is released.
> - SecureSentryInfoHandler is required until SOLR-5682 is committed, then we can get rid of it
> - There are some version issues with hadoop, because the versions that come from solr are different than the versions that sentry wants.  I'm not sure the best way to handle this (do you exclude all the hadoop dependencies from all the solr dependencies?).  For now, I've just added hadoop-hdfs to the dependency management, which guarantees that we always get the version that sentry wants and seems to fix all the issues.  Maybe we should add all the dependent hadoop jars to the dependency management section?  Any maven expert have a better idea?
> 
> 
> Diffs
> -----
> 
>   pom.xml 7db0088 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java 05c5263 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/ModifiableUserAuthenticationFilter.java b7081ba 
>   sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SecureSentryInfoHandler.java PRE-CREATION 
>   sentry-tests/sentry-tests-solr/src/test/resources/solr/solr-no-core.xml 476b5bc 
> 
> Diff: https://reviews.apache.org/r/17760/diff/
> 
> 
> Testing
> -------
> 
> Ran the solr e2e tests, haven't run the hive tests.
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>