You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/18 10:04:02 UTC

[GitHub] [incubator-nuttx] jane2226 opened a new pull request #4850: fix(sensor): align for selftest interface define.

jane2226 opened a new pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850


   Align for selftest interface in struct sensor_ops_s
   
   Signed-off-by: songnannan <so...@xiaomi.com>
   
   ## Summary
   Align for selftest interface in struct sensor_ops_s
   ## Impact
   nothing
   ## Testing
   Test in my own EVB.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752798279



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.
+ * Note:         If setting calibvalue is failed, return errno, otherwise,
+ *               return OK.

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #4850: fix(sensor): align for selftest interface define.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#issuecomment-972832729


   Hi @jane2226 we are getting errors on HEAD of the master:
   ```
   In file included from sensors/wtgahrs2.c:37:
   sensors/wtgahrs2.c: In function 'wtgahrs2_gps_data':
   Error: sensors/wtgahrs2.c:332:14: error: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t' {aka 'long unsigned int'} [-Werror=format=]
     332 |       sninfo("Time : %llu utc_time: %llu\n",
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     333 |              rtdata->gps.timestamp, rtdata->gps.time_utc);
         |              ~~~~~~~~~~~~~~~~~~~~~
         |                         |
         |                         uint64_t {aka long unsigned int}
   sensors/wtgahrs2.c:332:25: note: format string is defined here
     332 |       sninfo("Time : %llu utc_time: %llu\n",
         |                      ~~~^
         |                         |
         |                         long long unsigned int
         |                      %lu
   In file included from sensors/wtgahrs2.c:37:
   Error: sensors/wtgahrs2.c:332:14: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'uint64_t' {aka 'long unsigned int'} [-Werror=format=]
     332 |       sninfo("Time : %llu utc_time: %llu\n",
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     333 |              rtdata->gps.timestamp, rtdata->gps.time_utc);
         |                                     ~~~~~~~~~~~~~~~~~~~~
         |                                                |
         |                                                uint64_t {aka long unsigned int}
   sensors/wtgahrs2.c:332:40: note: format string is defined here
     332 |       sninfo("Time : %llu utc_time: %llu\n",
         |                                     ~~~^
         |                                        |
         |                                        long long unsigned int
         |                                     %lu
   cc1: all warnings being treated as errors
   make[1]: *** [Makefile:110: wtgahrs2.o] Error 1
   make[1]: Target 'libdrivers.a' not remade because of errors.
   make: *** [tools/LibTargets.mk:89: drivers/libdrivers.a] Error 2
   sensortest.c: In function 'print_gps':
   Error: sensortest.c:169:29: error: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t' {aka 'long unsigned int'} [-Werror=format=]
     169 |   printf("%s: timestamp: %llu time_utc: %llu latitude: %f longitude: %f "
         |                          ~~~^
         |                             |
         |                             long long unsigned int
         |                          %lu
   ......
     172 |          " %u\n", name, event->timestamp, event->time_utc, event->latitude,
         |                         ~~~~~~~~~~~~~~~~
         |                              |
         |                              uint64_t {aka long unsigned int}
   Error: sensortest.c:169:44: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'uint64_t' {aka 'long unsigned int'} [-Werror=format=]
     169 |   printf("%s: timestamp: %llu time_utc: %llu latitude: %f longitude: %f "
         |                                         ~~~^
         |                                            |
         |                                            long long unsigned int
         |                                         %lu
   ......
     172 |          " %u\n", name, event->timestamp, event->time_utc, event->latitude,
         |                                           ~~~~~~~~~~~~~~~
         |                                                |
         |                                                uint64_t {aka long unsigned int}
   sensortest.c: In function 'print_gps_satellite':
   Error: sensortest.c:183:29: error: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t' {aka 'long unsigned int'} [-Werror=format=]
     183 |   printf("%s: timestamp: %llu count: %u satellites: %u", name,
         |                          ~~~^
         |                             |
         |                             long long unsigned int
         |                          %lu
     184 |          event->timestamp, event->count, event->satellites);
         |          ~~~~~~~~~~~~~~~~    
         |               |
         |               uint64_t {aka long unsigned int}
   cc1: all warnings being treated as errors
   make[3]: *** [/github/workspace/sources/apps/Application.mk:192: sensortest.c.github.workspace.sources.apps.testing.sensortest.o] Error 1
   make[3]: Target 'all' not remade because of errors.
   make[2]: *** [Makefile:42: /github/workspace/sources/apps/testing/sensortest_all] Error 2
   make[2]: Target '/github/workspace/sources/apps/libapps.a' not remade because of errors.
   make[1]: *** [Makefile:36: all] Error 2
   make: *** [tools/LibTargets.mk:210: /github/workspace/sources/apps/libapps.a] Error 2
   make: Target 'all' not remade because of errors.
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 252: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
     Normalize sim/sensor
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 merged pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752539147



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.

Review comment:
       ```suggestion
    * Argument:     Calibration value for the sensor.
   ```

##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.
+ * Note:         If setting calibvalue is failed, return errno, otherwise,

Review comment:
       ```suggestion
    * Note:         If setting calibvalue failed, return errno, otherwise,
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752539473



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.
+ * Note:         If setting calibvalue is failed, return errno, otherwise,

Review comment:
       ```suggestion
    * Note:         If setting calibvalue failed, a negated errno value is returned, otherwise,
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4850: fix(sensor): align for selftest interface define.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#issuecomment-972836487


   @acassis the fix is here https://github.com/apache/incubator-nuttx/pull/4846


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jane2226 commented on pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
jane2226 commented on pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#issuecomment-974020907


   > LGTM!
   
   Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752542213



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.
+ * Note:         If setting calibvalue is failed, return errno, otherwise,
+ *               return OK.

Review comment:
       ```suggestion
    * Note:         If setting calibvalue failed, a negated errno value is return,
    *               otherwise, OK is returned.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752798312



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#discussion_r752542213



##########
File path: include/nuttx/sensors/ioctl.h
##########
@@ -297,4 +297,14 @@
 
 #define SNIOC_SELFTEST             _SNIOC(0x0086)
 
+/* Command:      SNIOC_SET_CALIBVALUE
+ * Description:  Set calibration value for sensor.
+ * Argument:     A argument of calibration value for sensor.
+ * Note:         If setting calibvalue is failed, return errno, otherwise,
+ *               return OK.

Review comment:
       ```suggestion
    * Note:         If setting calibvalue failed, a negated errno value is returned,
    *               otherwise, OK is returned.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jane2226 commented on pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
jane2226 commented on pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#issuecomment-974021145


   > @Ouss4 could you take a look?
   
   Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4850: feature: sensor: add set calibration interface

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4850:
URL: https://github.com/apache/incubator-nuttx/pull/4850#issuecomment-973929648


   @Ouss4 could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org