[superset] branch master updated: test: Fix act errors in DatabaseModal test (#22846)

[ly...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 262c947273 test: Fix act errors in DatabaseModal test (#22846)
262c947273 is described below

commit 262c9472730a2c706e53cf2c29346eade4a161ce
Author: Lyndsi Kay Williams <55...@users.noreply.github.com>
AuthorDate: Wed Jan 25 07:36:19 2023 -0600

    test: Fix act errors in DatabaseModal test (#22846)
---
 .../data/database/DatabaseModal/index.test.tsx     | 31 +++++++++++++---------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.tsx
index 2b064f6c10..5d58060155 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.tsx
@@ -43,6 +43,25 @@ jest.mock('@superset-ui/core', () => ({
   isFeatureEnabled: () => true,
 }));
 
+jest.mock('src/components/Icons/Icon', () => ({
+  __esModule: true,
+  default: ({
+    fileName,
+    role,
+    ...rest
+  }: {
+    fileName: string;
+    role: string;
+  }) => (
+    <span
+      role={role ?? 'img'}
+      aria-label={fileName.replace('_', '-')}
+      {...rest}
+    />
+  ),
+  StyledIcon: () => <span />,
+}));
+
 const dbProps = {
   show: true,
   database_name: 'my database',
@@ -354,11 +373,6 @@ describe('DatabaseModal', () => {
       const preferredDbTextSQLite = within(preferredDbButtonSQLite).getByText(
         /sqlite/i,
       );
-      // All dbs render with this icon in this testing environment,
-      // The Icon count should equal the count of databases rendered
-      const preferredDbIcon = screen.getAllByRole('img', {
-        name: /default-icon/i,
-      });
       // renderAvailableSelector() => <Select> - Supported databases selector
       const supportedDbsHeader = screen.getByRole('heading', {
         name: /or choose from a list of other databases we support:/i,
@@ -399,10 +413,6 @@ describe('DatabaseModal', () => {
         preferredDbButtonPresto,
         preferredDbButtonMySQL,
         preferredDbButtonSQLite,
-        preferredDbIcon[0],
-        preferredDbIcon[1],
-        preferredDbIcon[2],
-        preferredDbIcon[3],
         preferredDbTextPostgreSQL,
         preferredDbTextPresto,
         preferredDbTextMySQL,
@@ -414,9 +424,6 @@ describe('DatabaseModal', () => {
       });
       // there should be a footer but it should not have any buttons in it
       expect(footer[0]).toBeEmptyDOMElement();
-
-      // This is how many preferred databases are rendered
-      expect(preferredDbIcon).toHaveLength(5);
     });
 
     test('renders the "Basic" tab of SQL Alchemy form (step 2 of 2) correctly', async () => {