You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/11/10 01:20:40 UTC

[PR] [#2523]fix problem when client api do not provide file parameter [servicecomb-java-chassis]

liubao68 opened a new pull request, #4021:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4021

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [#2523]fix problem when client api do not provide file parameter [servicecomb-java-chassis]

Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4021:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [#2523]fix problem when client api do not provide file parameter [servicecomb-java-chassis]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4021:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4021#issuecomment-1804998450

   ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#4021](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (022a2f4) into [master](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/c313c605f6a6a78c31d23e021c1f53ba7d3a04c4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c313c60) will **increase** coverage by `0.46%`.
   > Report is 1 commits behind head on master.
   > The diff coverage is `93.75%`.
   
   > :exclamation: Current head 022a2f4 differs from pull request most recent head c601722. Consider uploading reports for the commit c601722 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4021      +/-   ##
   ============================================
   + Coverage     43.94%   44.40%   +0.46%     
   - Complexity     5369     5423      +54     
   ============================================
     Files          1388     1389       +1     
     Lines         34312    34339      +27     
     Branches       3359     3359              
   ============================================
   + Hits          15078    15248     +170     
   + Misses        18009    17863     -146     
   - Partials       1225     1228       +3     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/servicecomb/common/rest/RestConst.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9SZXN0Q29uc3QuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [.../demo/edge/consumer/EdgeServiceGovernanceTest.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGVtby9kZW1vLWVkZ2UvY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vZWRnZS9jb25zdW1lci9FZGdlU2VydmljZUdvdmVybmFuY2VUZXN0LmphdmE=) | `85.33% <100.00%> (ø)` | |
   | [...oot/springmvc/client/UploadDownloadSchemaTest.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGVtby9kZW1vLXNwcmluZy1ib290LXRyYW5zcG9ydC9kZW1vLXNwcmluZy1ib290LXNwcmluZ212Yy1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NwcmluZ2Jvb3Qvc3ByaW5nbXZjL2NsaWVudC9VcGxvYWREb3dubG9hZFNjaGVtYVRlc3QuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...e/servicecomb/edge/core/EdgeInvocationCreator.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZWRnZS9lZGdlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2VkZ2UvY29yZS9FZGdlSW52b2NhdGlvbkNyZWF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...t/rest/client/RestClientRequestParametersImpl.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9SZXN0Q2xpZW50UmVxdWVzdFBhcmFtZXRlcnNJbXBsLmphdmE=) | `86.48% <100.00%> (-0.36%)` | :arrow_down: |
   | [...omb/common/rest/RestProducerInvocationCreator.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9SZXN0UHJvZHVjZXJJbnZvY2F0aW9uQ3JlYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4021/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org