You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "benjamin-confino (via GitHub)" <gi...@apache.org> on 2024/07/16 09:26:27 UTC
[PR] Document interaction between peek and filter iterator [commons-collections]
benjamin-confino opened a new pull request, #515:
URL: https://github.com/apache/commons-collections/pull/515
Resolves: https://issues.apache.org/jira/browse/COLLECTIONS-856
This documents the interaction between a peeking iterator and a filtering iterator; that if you call `peek()` or `element()`, `fill()` will put the next predicate approved element from the underlying filtering iterator, stash it in `slot`, ensuring it will be returned in the future even if the object changes and no longer matches the predicate.
(This PR also removes an incorrect line saying `element()` will return null if the underlying iterator is exhausted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document interaction between peek and filter iterator [commons-collections]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #515:
URL: https://github.com/apache/commons-collections/pull/515#issuecomment-2424890405
As I could not resolve the conflicts from here, I committed this directly to git master with @benjamin-confino as the author. TY for you patience! Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document interaction between peek and filter iterator [commons-collections]
Posted by "benjamin-confino (via GitHub)" <gi...@apache.org>.
benjamin-confino commented on PR #515:
URL: https://github.com/apache/commons-collections/pull/515#issuecomment-2434732382
@garydgregory No worries, and thanks for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document interaction between peek and filter iterator [commons-collections]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #515: Document interaction between peek and filter iterator
URL: https://github.com/apache/commons-collections/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org