[GitHub] [incubator-superset] john-bodley commented on pull request #9637: [WIP][explore view] add partition as adhoc filter option

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #9637:
URL: https://github.com/apache/incubator-superset/pull/9637#issuecomment-618797080


   @graceguo-superset thanks for adding this. I think directionally it’s correct, i.e., a user friendly mechanism to a feature which only savvy users are probably aware of. 
   
   I agree with @ktmud’s comments including the design suggestion.
   
   @ktmud in the example for a multi-partitioned table the `hr` filter applies to the latest `date` I believe (I need to look at the backend code). Regardless for multi-partitioned tables we should probably think how best to indicate what the filter entails.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org