You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/08 08:00:29 UTC
[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #3279:
[BUG] Fix cast result expr bug
HangyuanLiu opened a new pull request #3279: [BUG] Fix cast result expr bug
URL: https://github.com/apache/incubator-doris/pull/3279
For #3275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request
#3279: [BUG] Fix cast result expr bug
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on a change in pull request #3279: [BUG] Fix cast result expr bug
URL: https://github.com/apache/incubator-doris/pull/3279#discussion_r405510789
##########
File path: fe/src/main/java/org/apache/doris/analysis/StatementBase.java
##########
@@ -124,6 +124,9 @@ public void castResultExprs(List<Type> types) throws AnalysisException {
Preconditions.checkNotNull(resultExprs);
Preconditions.checkState(resultExprs.size() == types.size());
for (int i = 0; i < types.size(); ++i) {
+ if (resultExprs.get(i).getType().isDateType() && types.get(i).isDateType()) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3279: [BUG] Fix cast result expr bug
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3279: [BUG] Fix cast result expr bug
URL: https://github.com/apache/incubator-doris/pull/3279#discussion_r405505398
##########
File path: fe/src/main/java/org/apache/doris/analysis/StatementBase.java
##########
@@ -124,6 +124,9 @@ public void castResultExprs(List<Type> types) throws AnalysisException {
Preconditions.checkNotNull(resultExprs);
Preconditions.checkState(resultExprs.size() == types.size());
for (int i = 0; i < types.size(); ++i) {
+ if (resultExprs.get(i).getType().isDateType() && types.get(i).isDateType()) {
Review comment:
Please add a detailed comment here to explain the problem. Specific examples can be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3279: [BUG] Fix
cast result expr bug
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3279: [BUG] Fix cast result expr bug
URL: https://github.com/apache/incubator-doris/pull/3279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org