You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/26 15:37:27 UTC

[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1921: fix: regex & omit vars when no value

iamayushdas removed a comment on pull request #1921:
URL: https://github.com/apache/apisix-dashboard/pull/1921#issuecomment-848855816


   > ![image](https://user-images.githubusercontent.com/72343596/119684898-777d0600-be77-11eb-9f7d-faaa472d7cdb.png)
   > It is better to add this assertion after line 222 to ensure that the vars field disappears.
   > 
   > ```
   >       cy.contains('vars').should('not.exist');
   > ```
   
   i thought its not necessary, will add this line too , thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org