You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2015/08/17 17:48:52 UTC

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

GitHub user ygy opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/834

    Adding --replacepkgs parameter to ensure proper epel install

    - rpm -Uvh exits with 1 if it is already installed
    - replacepkgs ensures that the package will be properly updated
      or replaced if already installed
    
    The proposed fix is needed for compatibility between CentOS and RHEL.
    RedHat doesn't have EPEL repo enabled by default, but CentOS has.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ygy/incubator-brooklyn fix/epel-install-rabbitmq

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit c38f8ad4e51ce8792343a67432eca48bcb290192
Author: Yavor Yanchev <ya...@yanchev.com>
Date:   2015-08-17T15:42:46Z

    Adding --replacepkgs parameter to ensure proper epel install
    
    - rpm -Uvh exits with 1 if it is already installed
    - replacepkgs ensures that the package will be properly updated
      or replaced if already installed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/834#issuecomment-132163800
  
    Share slight hesitation but agree better than not doing it.
    
    This is a good argument for using YAML to describe this, so people have increased visibility into what is happening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by ygy <gi...@git.apache.org>.
Github user ygy closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/834#issuecomment-132158051
  
    Thanks @ygy 
    
    Just to clarify, does it work previously on RHEL (which does not have EPEL), but fails on CentOS (which does have EPEL repo enabled)?
    
    I'm slightly hesitant about use of `--replacepkgs`. Any implications for if we are upgrading/downgrading the EPEL packages, for other stuff installed on the OS?
    
    On balance, I think it's fine to merge but would appreciate other's opinions: @grkvlt @richardcloudsoft @ahgittin 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by ygy <gi...@git.apache.org>.
GitHub user ygy reopened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/834

    Adding --replacepkgs parameter to ensure proper epel install

    - rpm -Uvh exits with 1 if it is already installed
    - replacepkgs ensures that the package will be properly updated
      or replaced if already installed
    
    The proposed fix is needed for compatibility between CentOS and RHEL.
    RedHat doesn't have EPEL repo enabled by default, but CentOS has.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ygy/incubator-brooklyn fix/epel-install-rabbitmq

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit c38f8ad4e51ce8792343a67432eca48bcb290192
Author: Yavor Yanchev <ya...@yanchev.com>
Date:   2015-08-17T15:42:46Z

    Adding --replacepkgs parameter to ensure proper epel install
    
    - rpm -Uvh exits with 1 if it is already installed
    - replacepkgs ensures that the package will be properly updated
      or replaced if already installed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by ygy <gi...@git.apache.org>.
Github user ygy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/834#issuecomment-132174703
  
    @ahgittin thanks for merging
    
    @aledsage yes, it worked on RHEL
    
    There will be no implications during upgrades/downgrades. The rpm packages is installed with parameters "-Uvh" (upgrade or install), but not "ivh" (only install).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/834#issuecomment-135898800
  
    This fixes https://issues.apache.org/jira/browse/BROOKLYN-159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Adding --replacepkgs parameter to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---