[jira] [Commented] (CB-12159) Android: Keystore password prompt won't show up

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722528#comment-15722528 ] 

ASF GitHub Bot commented on CB-12159:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-android/pull/351

    CB-12159 Android: Keystore password prompt won't show up

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Makes password prompt to work for newer Gradle versions.
    
    ### What testing has been done on this change?
    Run auto tests.
    
    Jira: [CB-12159](https://issues.apache.org/jira/browse/CB-12159)
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-android CB-12159

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #351
    
----
commit 283c5e4b203fd17a7525c1def44608951d45581d
Author: daserge <v-...@microsoft.com>
Date:   2016-12-05T15:21:28Z

    CB-12159 Android: Keystore password prompt won't show up

----


> Android: Keystore password prompt won't show up
> -----------------------------------------------
>
>                 Key: CB-12159
>                 URL: https://issues.apache.org/jira/browse/CB-12159
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Teemu Halmela
>              Labels: android, gradle, keystore, password, prompt, reproduced, triaged
>
> After updating platform to Android 6.0.0 keystore password prompt won't work anymore.
> This happens when doing release build with command
> {noformat}
> cordova build --release --buildConfig build.json
> {noformat}
> Where build.json contains keystore and alias properties.
> On previous version this showed a prompt that asked for keystore passwords.
> With new version build fails with an error because it won't have the correct passwords.
> {noformat}
> Execution failed for task ':packageArmv7Release'.
> > com.android.ide.common.signing.KeytoolException: Failed to read key STORE from store "KEYSTORE": Keystore was tampered with, or password was incorrect
> {noformat}
> I'm using Cordova 6.4.0 and have tested this with Android 5.1.1 and 5.2.2 and both of those work. Android 6.1.0 has the same issue.
> It seems to me that validateReleaseSigning task isn't being added to gradle tasks anymore for some reason, which means prompt won't be shown.
> I think this function is supposed to show the prompt 
> {code:javascript|title=platforms/android/build.gradle}
> gradle.taskGraph.whenReady { taskGraph ->
>     taskGraph.getAllTasks().each() { task ->
>         if (task.name == 'validateReleaseSigning') {
>             promptForReleaseKeyPassword()
>         }
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org