[GitHub] [iceberg] flyrain commented on pull request #2608: Core : Repair manifests

[GitBox <gi...@apache.org>]

flyrain commented on pull request #2608:
URL: https://github.com/apache/iceberg/pull/2608#issuecomment-844426726


   > @flyrain thanks for the review, so to understand, you would prefer a result of Map of individual manifest-entry changes instead of a summary of manifest-files changed? I was thinking that but was fearing it would be too big of a result.
   
   Yes. Map works here. Your concern is valid. The size varies dramatically. For a table with 1TB data, if the average file size is 256M, we got 1000000/256 = 4,000 data files, we probably needs 100 bytes for each data files, which is about 400M data, that sounds too much to me as well.
   
   In that sense, I'm OK with the current implementation, we can think about the different way to handle the future requirement.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org