You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/24 02:48:52 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15252: [improve][broker] Tidy up the system topic.

congbobo184 commented on code in PR #15252:
URL: https://github.com/apache/pulsar/pull/15252#discussion_r857056518


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1372,11 +1373,18 @@ public static String getSLAMonitorBrokerName(ServiceUnitId ns) {
     }
 
     public static boolean isSystemServiceNamespace(String namespace) {
-        return HEARTBEAT_NAMESPACE_PATTERN.matcher(namespace).matches()
+        return SYSTEM_NAMESPACE.toString().equals(namespace)
+                || HEARTBEAT_NAMESPACE_PATTERN.matcher(namespace).matches()

Review Comment:
   may can use isHeartbeatNamespace()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org