[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2690: chore: optimize "allow_origins_by_regex tooltip" description

[GitBox <gi...@apache.org>]

bzp2010 commented on code in PR #2690:
URL: https://github.com/apache/apisix-dashboard/pull/2690#discussion_r1048076344


##########
web/src/components/Plugin/locales/en-US.ts:
##########
@@ -49,7 +49,7 @@ export default {
   'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
     'Match which origin is allowed to enable CORS by referencing allow_origins set in plugin metadata.',
   'component.pluginForm.cors.allow_origins_by_regex.tooltip':
-    'Use regex expressions to match which origin is allowed to enable CORS, for example, [".*.test.com"] can use to match all subdomain of test.com.',
+    'Use regex expressions to match which origin is allowed to enable CORS. Each form can only be configured with a single, standalone regular expression, such as ".*.test.com" which can match any subdomain of test.com.',

Review Comment:
   ```suggestion
       'Use regex expressions to match which origin is allowed to enable CORS. Each input box can only be configured with a single, standalone regular expression, such as ".*.test.com" which can match any subdomain of test.com.',
   ```



##########
web/src/components/Plugin/locales/tr-TR.ts:
##########
@@ -49,7 +49,7 @@ export default {
   'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
     'Eklenti meta verilerindeki allow_origins kümesine başvurarak CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirin.',
   'component.pluginForm.cors.allow_origins_by_regex.tooltip':
-    'CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirmek için normal ifade ifadeleri kullanın, örneğin, [".*.test.com"], test.comun tüm alt alan adlarını eşleştirmek için kullanabilir.',
+    'CORSu etkinleştirmek için izin verilen kaynakları eşleştirmek için regex ifadelerini kullanın. Her form sadece tek bir, bağımsız düzenli ifadeyle yapılandırılabilir, örneğin ".*.test.com" gibi, test.com\'un her alt etki alanını eşleştirebilir.',

Review Comment:
   ditto



##########
web/src/components/Plugin/locales/zh-CN.ts:
##########
@@ -48,7 +48,7 @@ export default {
   'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
     '通过引用插件元数据的 allow_origins 配置允许跨域访问的 Origin。',
   'component.pluginForm.cors.allow_origins_by_regex.tooltip':
-    '使用正则表达式数组来匹配允许跨域访问的 Origin, 如[".*.test.com"] 可以匹配任何test.com的子域名 * 。',
+    '使用正则表达式来匹配允许跨域访问的 Origin, 每一个表单仅可以配置一个独立的正则表达式，如".*.test.com" 可以匹配任何test.com的子域名 * 。',

Review Comment:
   ```suggestion
       '使用正则表达式来匹配允许跨域访问的 Origin, 每一个输入框仅可以配置一个独立的正则表达式，如".*.test.com" 可以匹配任何test.com的子域名 * 。',
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org