[GitHub] [hbase] virajjasani commented on a change in pull request #3295: HBASE-25890 [Addendum] create profiles for different jdk version

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #3295:
URL: https://github.com/apache/hbase/pull/3295#discussion_r641403462



##########
File path: pom.xml
##########
@@ -60,30 +60,6 @@
     </license>
   </licenses>
 
-  <modules>
-    <module>hbase-resource-bundle</module>
-    <module>hbase-server</module>
-    <module>hbase-rest</module>
-    <module>hbase-shell</module>
-    <module>hbase-protocol</module>
-    <module>hbase-client</module>
-    <module>hbase-hadoop-compat</module>
-    <module>hbase-common</module>
-    <module>hbase-procedure</module>
-    <module>hbase-it</module>
-    <module>hbase-examples</module>
-    <module>hbase-prefix-tree</module>
-    <module>hbase-assembly</module>
-    <module>hbase-testing-util</module>
-    <module>hbase-annotations</module>
-    <module>hbase-checkstyle</module>
-    <module>hbase-external-blockcache</module>
-    <module>hbase-shaded</module>
-    <module>hbase-archetypes</module>
-    <module>hbase-metrics-api</module>
-    <module>hbase-metrics</module>
-    <module>hbase-hbtop</module>
-  </modules>

Review comment:
       @Reidddddd Just to understand this better, is it possible to keep modules here as is and then override in specific profile if required? Like we continue to have this and then JDK7 can override this, so that default profile would not have to define <modules> again.
   The problem is, IDEs might not be able to identify these modules by parsing pom.xml. Thoughts?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org