[GitHub] [spark] Shockang commented on a change in pull request #33674: [WIP][Spark-36328][CORE][SQL] Reuse the FileSystem delegation token while querying partitioned hive table.

[GitBox <gi...@apache.org>]

Shockang commented on a change in pull request #33674:
URL: https://github.com/apache/spark/pull/33674#discussion_r698021092



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##########
@@ -378,6 +387,9 @@ class HadoopTableReader(
   private def createNewHadoopRDD(partDesc: PartitionDesc, path: String): RDD[Writable] = {
     val newJobConf = new JobConf(hadoopConf)
     HadoopTableReader.initializeLocalJobConfFunc(path, partDesc.getTableDesc)(newJobConf)
+    // SPARK-36328: Reuse the FileSystem delegation token while querying partitioned hive table.
+    SparkHadoopUtil.get.addCurrentCredentials(newJobConf,
+      _broadcastedCredentials.value.value)

Review comment:
       I'll delete it. I added it because considering that the new Hadoop API will make it easier to reuse tokens, but it violates the principle of minimizing modification points. @c21 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org