You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Phabricator (Updated) (JIRA)" <ji...@apache.org> on 2012/02/03 01:14:54 UTC
[jira] [Updated] (HBASE-5292) getsize per-CF metric incorrectly
counts compaction related reads as well
[ https://issues.apache.org/jira/browse/HBASE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5292:
-------------------------------
Attachment: D1527.3.patch
zhiqiu updated the revision "[jira] [HBASE-5292] [89-fb] Prevent counting getSize on compactions".
Reviewers: Kannan, Liyin, JIRA
Address Kannan's comments:
* Removed the metric name Hashset
* Re-based on Liyin's fix of "..getsize"
REVISION DETAIL
https://reviews.facebook.net/D1527
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/regionserver/InternalScanner.java
src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
> getsize per-CF metric incorrectly counts compaction related reads as well
> --------------------------------------------------------------------------
>
> Key: HBASE-5292
> URL: https://issues.apache.org/jira/browse/HBASE-5292
> Project: HBase
> Issue Type: Bug
> Reporter: Kannan Muthukkaruppan
> Attachments: D1527.1.patch, D1527.2.patch, D1527.3.patch
>
>
> The per-CF "getsize" metric's intent was to track bytes returned (to HBase clients) per-CF. [Note: We already have metrics to track # of HFileBlock's read for compaction vs. non-compaction cases -- e.g., compactionblockreadcnt vs. fsblockreadcnt.]
> Currently, the "getsize" metric gets updated for both client initiated Get/Scan operations as well for compaction related reads. The metric is updated in StoreScanner.java:next() when the Scan query matcher returns an INCLUDE* code via a:
> HRegion.incrNumericMetric(this.metricNameGetsize, copyKv.getLength());
> We should not do the above in case of compactions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira