You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/07/16 12:27:45 UTC
[GitHub] [incubator-tubemq] lubanproj opened a new pull request #209: [TUBEMQ-284] Protocol support for go client
lubanproj opened a new pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209
Protocol support for go client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on pull request #209: [TUBEMQ-284] Protocol support for go client
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209#issuecomment-659449182
@lubanproj you need rebase the code and then pull request.
many history prs are pulled in this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] lubanproj closed pull request #209: [TUBEMQ-284] Protocol support for go client
Posted by GitBox <gi...@apache.org>.
lubanproj closed pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] liangyuanpeng commented on a change in pull request #209: [TUBEMQ-284] Protocol support for go client
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on a change in pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209#discussion_r456479553
##########
File path: tubemq-client-twins/tubemq-client-go/consumer.go
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package tubeclient
+
+import "errors"
+
+// Consumer defines a basic contract that all consumers need to follow
+type Consumer interface {
+ // Subscribe defines a subscription to the topic
+ Subscribe(topic string)
+}
+
+// PullConsumer implements Consumber with the pull consumption
+type PullConsumer struct {
+ config *Config
+}
+
+// New create a PullConsumer instance
+func New(config *Config) *PullConsumer {
Review comment:
Maybe we can create some test for new consumer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org