You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2025/01/05 03:49:34 UTC
[PR] Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
maobaolong opened a new pull request, #2323:
URL: https://github.com/apache/incubator-uniffle/pull/2323
### What changes were proposed in this pull request?
Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize
### Why are the changes needed?
Do some efforts to make Ci more stable.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong merged PR #2323:
URL: https://github.com/apache/incubator-uniffle/pull/2323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2323:
URL: https://github.com/apache/incubator-uniffle/pull/2323#issuecomment-2571494826
## Test Results
2 966 files ±0 2 966 suites ±0 6h 27m 37s ⏱️ +19s
1 100 tests ±0 1 098 ✅ ±0 2 💤 ±0 0 ❌ ±0
13 774 runs ±0 13 744 ✅ ±0 30 💤 ±0 0 ❌ ±0
Results for commit 86f5ebed. ± Comparison against base commit 3b0521ab.
[test-results]:data:application/gzip;base64,H4sIAE0HemcC/02MSQ7DIBAEv2JxzsFmmTH5TMQqoXiJMJys/D3geDtWzXStxIfBLeTZUAnwaMiSQ7qzzVGlME/VMCqwqHJP9aPr2vbA15KNqa6V/eXe4VN3p/AqDEVcKxfjHHcT87RVGSLf8awy5Jf7V9mxuVc3vkfNPI4hFSA9eOG0s1QKipZqp6kH7FXHDQAajVyAkkyS7w+LSsUjFAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2323: [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize
URL: https://github.com/apache/incubator-uniffle/pull/2323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2323:
URL: https://github.com/apache/incubator-uniffle/pull/2323#issuecomment-2571499588
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2323?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 51.60%. Comparing base [(`580b4f2`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/580b4f2a45886d311b7b3f9d032a505f3e02d983?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9e405f0`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/9e405f02f196241ff872251efd20d01cf23d1881?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2323 +/- ##
============================================
+ Coverage 51.19% 51.60% +0.40%
- Complexity 2936 2972 +36
============================================
Files 486 474 -12
Lines 24720 22683 -2037
Branches 2041 2090 +49
============================================
- Hits 12656 11705 -951
+ Misses 11274 10233 -1041
+ Partials 790 745 -45
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2323?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] fix(test): Fix flaky test for CoordinatorGrpcServerTest#testGrpcConnectionSize [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2323:
URL: https://github.com/apache/incubator-uniffle/pull/2323#issuecomment-2576542046
@jerqi Thanks for your review! Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org