You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/11 15:37:41 UTC

[jira] [Commented] (ARTEMIS-1110) AMQP Transaction controller can reuse a single buffer for decoding commands

    [ https://issues.apache.org/jira/browse/ARTEMIS-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964529#comment-15964529 ] 

ASF GitHub Bot commented on ARTEMIS-1110:
-----------------------------------------

GitHub user tabish121 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1197

    ARTEMIS-1110 Cleanup Transaction Coordinator buffer handling

    Resuse a single small buffer for all txn commands (declare / dischare) to
    avoid creating lots of small arrays and ByteBuffer wrappers for txn operations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1110

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1197
    
----
commit d2731fa0e1d66831ad95011ff00a76727bd7d5e8
Author: Timothy Bish <ta...@gmail.com>
Date:   2017-04-11T15:16:26Z

    ARTEMIS-1110 Cleanup Transaction Coordinator buffer handling
    
    Resuse a single small buffer for all txn commands (declare / dischare) to
    avoid creating lots of small arrays and ByteBuffer wrappers for txn operations.

----


> AMQP Transaction controller can reuse a single buffer for decoding commands
> ---------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1110
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1110
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: AMQP
>    Affects Versions: 2.0.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>             Fix For: 2.next
>
>
> The AMQP transaction controller can reuse a single small buffer for decoding commands instead of creating a new array and then a wrapped ByteBuffer for every declare discharge which reduces garbage created from the controller for each TX cycle.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)