You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2024/09/08 02:08:09 UTC
Re: [PR] Global limit for MSQ controller tasks implemented (druid)
cryptoe commented on code in PR #16889:
URL: https://github.com/apache/druid/pull/16889#discussion_r1749038520
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -440,7 +442,7 @@ private void manageInternalCritical(
notifyStatus(task, taskStatus, taskStatus.getErrorMsg());
continue;
}
- if (taskIsReady) {
+ if (taskIsReady && !isControllerTaskLimitReached(task.getType(), true)) {
Review Comment:
Should It just be limited to MSQ controllers or other job types as well. Maybe Take a json as a input ? where key is the taskType and the value is the limit/float.
Also what is the user behavior if the task is pending for launch due to limit.
* Can we communicate why the task is not launching to the user.
* If the cluster is totally starved, does the controller get timed out eventually and removed from queue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org