You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@wyona.com> on 2006/09/13 13:23:49 UTC

Re: svn commit: r442869 - in /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources: ./ themes/ themes/pelt.fv

I am not 100% sure.

I do not like the idea of maintaining the pelt as well in x plugins. We
should refactor the pelt structurer and use tiles (like the export links
in the common.fv -> <jx:import
uri="cocoon://prepare.tiles.export-link"/>) for all properties/contracts
that probably need to be changed on a plugin base.

This way we only need to add this parts and have less maintenance.

salu2


On Wed, 2006-09-13 at 06:54 +0000, crossley@apache.org wrote:
> Author: crossley
> Date: Tue Sep 12 23:54:06 2006
> New Revision: 442869
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=442869
> Log:
> The Dispatcher plugin is using Dispatcher for its docs, so need a project structurer pelt.fv
> Only need to change a couple of things from the default: copyright notice, logo, and breadtrail.
> 
> Added:
>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/
>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/
>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv
>       - copied, changed from r442770, forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv
> 
> Copied: forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv (from r442770, forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv)
> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv?view=diff&rev=442869&p1=forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv&r1=442770&p2=forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv&r2=442869
> ==============================================================================
> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv (original)
> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv Tue Sep 12 23:54:06 2006
> @@ -223,8 +223,7 @@
>        <forrest:contract name="branding-breadcrumbs">
>          <forrest:property name="branding-breadcrumbs">
>            <trail>
> -            <link1 name="MyGroup" href="http://www.apache.org/"/>
> -            <link2 name="MyProject" href="http://forrest.apache.org/"/>
> +            <link1 name="Apache Forrest" href="http://forrest.apache.org/"/>
>            </trail>
>          </forrest:property>
>        </forrest:contract>
> @@ -237,24 +236,21 @@
>          </forrest:contract>
>          <forrest:hook class="logo">
>            <forrest:contract name="branding-logo">
> -            <forrest:property name="branding-logo-name">
> -              MyGroup</forrest:property>
> -            <forrest:property name="branding-logo-description">MyGroup 
> -              Description</forrest:property>
> +            <forrest:property name="branding-logo-name">Apache Forrest Logo</forrest:property>
> +            <forrest:property name="branding-logo-description">Apache Forrest</forrest:property>
>              <forrest:property name="branding-logo-url">
> -              http://mygroup.org/</forrest:property>
> +              http://forrest.apache.org/</forrest:property>
>              <forrest:property name="branding-logo-logo">
> -              images/group.png</forrest:property>
> +              images/project-logo.gif</forrest:property>
>            </forrest:contract>
>          </forrest:hook>
>          <forrest:hook class="logo">
>            <forrest:contract name="branding-logo">
> -            <forrest:property name="branding-logo-name">
> -              MyProject</forrest:property>
> -            <forrest:property name="branding-logo-description">MyProject 
> -              Description</forrest:property>
> +            <forrest:property name="branding-logo-name">plugin logo</forrest:property>
> +            <forrest:property name="branding-logo-description">
> +              org.apache.forrest.plugin.internal.dispatcher plugin for Apache Forrest</forrest:property>
>              <forrest:property name="branding-logo-url">
> -              http://myproj.mygroup.org/</forrest:property>
> +            http://forrest.apache.org/pluginDocs/</forrest:property>
>              <forrest:property name="branding-logo-logo">
>                images/project.png</forrest:property>
>            </forrest:contract>
> @@ -352,9 +348,11 @@
>            </forrest:contract>
>            <forrest:contract name="nav-section-round-bottom"/>
>          </forrest:hook>
> +<!--
>          <forrest:hook name="export-link">
>            <forrest:contract name="content-pdf-link"/>
>          </forrest:hook>
> +-->
>          <forrest:hook name="content">
>            <!-- FIXME - Problem with ndeSetTextSize() script from fontsize.js not compliant between Pelt and Leather-dev... -->
>            <!-- <forrest:hook class="trail">
> @@ -393,8 +391,8 @@
>              <forrest:property name="siteinfo-copyright">
>                <copyright>
>                  <year inception="true">2002</year>
> -                <vendor>The Acme Software Organisation.</vendor>
> -                <copyright-link>http://www.acme.org/licenses/</copyright-link>
> +                <vendor>The Apache Software Foundation.</vendor>
> +                <copyright-link>http://www.apache.org/licenses/</copyright-link>
>                </copyright>
>              </forrest:property>
>            </forrest:contract>
> 

-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org


Re: svn commit: r442869 - in /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources: ./ themes/ themes/pelt.fv

Posted by Thorsten Scherler <th...@wyona.com>.
On Thu, 2006-09-14 at 08:45 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> > I am not 100% sure.
> > 
> > I do not like the idea of maintaining the pelt as well in x plugins. We
> > should refactor the pelt structurer and use tiles (like the export links
> > in the common.fv -> <jx:import
> > uri="cocoon://prepare.tiles.export-link"/>) for all properties/contracts
> > that probably need to be changed on a plugin base.
> > 
> > This way we only need to add this parts and have less maintenance.
> 
> That would be good. We need to ease the maintenance.

+1

> 
> It was necessary to do something ASAP in this case because
> we were publishing information with the wrong copyright notice.
> 

Yes and thank you very much. I just picked it up because it have been a
long time in the back of my head and seeing your commit reminded me
again.

/me cannot wait to get internet@home again to get some work done. :/

salu2

> -David
> 
> > > Author: crossley
> > > Date: Tue Sep 12 23:54:06 2006
> > > New Revision: 442869
> > > 
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=442869
> > > Log:
> > > The Dispatcher plugin is using Dispatcher for its docs, so need a project structurer pelt.fv
> > > Only need to change a couple of things from the default: copyright notice, logo, and breadtrail.
> > > 
> > > Added:
> > >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/
> > >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/
> > >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv
> > >       - copied, changed from r442770, forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org


Re: svn commit: r442869 - in /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources: ./ themes/ themes/pelt.fv

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> I am not 100% sure.
> 
> I do not like the idea of maintaining the pelt as well in x plugins. We
> should refactor the pelt structurer and use tiles (like the export links
> in the common.fv -> <jx:import
> uri="cocoon://prepare.tiles.export-link"/>) for all properties/contracts
> that probably need to be changed on a plugin base.
> 
> This way we only need to add this parts and have less maintenance.

That would be good. We need to ease the maintenance.

It was necessary to do something ASAP in this case because
we were publishing information with the wrong copyright notice.

-David

> > Author: crossley
> > Date: Tue Sep 12 23:54:06 2006
> > New Revision: 442869
> > 
> > URL: http://svn.apache.org/viewvc?view=rev&rev=442869
> > Log:
> > The Dispatcher plugin is using Dispatcher for its docs, so need a project structurer pelt.fv
> > Only need to change a couple of things from the default: copyright notice, logo, and breadtrail.
> > 
> > Added:
> >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/
> >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/
> >     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/resources/themes/pelt.fv
> >       - copied, changed from r442770, forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv