You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/11/19 11:48:25 UTC

Review Request 28223: Alerts UI: Alerts summary Add "Pending" filter for status

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28223/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: ambari-8381
    https://issues.apache.org/jira/browse/ambari-8381


Repository: ambari


Description
-------

Add "Pending" value for Status filter.
Pending is true, if alert definition summary is {{0 OK / 0 WARN / 0 CRIT / 0 UNKNOWN}}


Diffs
-----

  ambari-web/app/views/common/filter_view.js 3a818d8 
  ambari-web/app/views/main/alert_definitions_view.js 6e9c276 
  ambari-web/test/views/common/filter_view_test.js 48ad66f 
  ambari-web/test/views/main/dashboard/widgets_test.js 4fdd6cd 

Diff: https://reviews.apache.org/r/28223/diff/


Testing
-------

 4849 tests complete (7 seconds)
   60 tests pending


Thanks,

Oleg Nechiporenko


Re: Review Request 28223: Alerts UI: Alerts summary Add "Pending" filter for status

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28223/#review62143
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Ноя. 19, 2014, 10:48 д.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28223/
> -----------------------------------------------------------
> 
> (Updated Ноя. 19, 2014, 10:48 д.п.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: ambari-8381
>     https://issues.apache.org/jira/browse/ambari-8381
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add "Pending" value for Status filter.
> Pending is true, if alert definition summary is {{0 OK / 0 WARN / 0 CRIT / 0 UNKNOWN}}
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/common/filter_view.js 3a818d8 
>   ambari-web/app/views/main/alert_definitions_view.js 6e9c276 
>   ambari-web/test/views/common/filter_view_test.js 48ad66f 
>   ambari-web/test/views/main/dashboard/widgets_test.js 4fdd6cd 
> 
> Diff: https://reviews.apache.org/r/28223/diff/
> 
> 
> Testing
> -------
> 
>  4849 tests complete (7 seconds)
>    60 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>