You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Oliver-Rainer Wittmann <or...@googlemail.com> on 2011/10/05 16:18:35 UTC

[patch} removal of OS2Bitmap.cxx

Hi,

attached you find the patch to remove 
main/dtrans/source/os2/clipb/OS2Bitmap.cxx due to missing license header.

This file was only of relevance for OS2, if OOO_VENDOR=="Serenity 
Systems Intl"

Can someone please review the patch and commit it to the reprository.

Thanks in advance,
Oliver.

Re: [patch} removal of OS2Bitmap.cxx

Posted by Yuri Dario <mc...@mclink.it>.
Hi Pedro,


> The problem is if the code doesn't carry a license it's
> assumed the code is proprietary and we cannot take it.

sure, but in this case I'm the writer of this code, so I can choose 
whatever license I prefer for my personal work.

> I personally prefer a BSD license for my work because
> I can't make any claims about patents but If the code
> you used as a template is from OOo, then we
> (actually you and only you) can add AL2 header on it.

since the other OS2* files in that module are coming from the same 
base, I think the OOo license is better suited for os2bitmap.cxx too.

> Sorry that contributing is such a mess, but you learn
> this stuff once and it works everywhere ;).

OOo past move to lgpl/gpl has created a lot of more problems in 
licensing for the code I contributed to Sun :-)

> I had no idea EMX had continued advancing.. cool :).

we use a new libc, named klibc which is based on emx but a lot better 
in many ways.


> free to send me a private message with a packaged version
> or submit it as an issue in the google code place.

sure!


> ps. If Ted Tsikora is still around there, tell him
> I said hi ;). 

I remember this name, but I never saw him on irc.

-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/



Re: [patch} removal of OS2Bitmap.cxx

Posted by Pedro Giffuni <pf...@apache.org>.
--- On Tue, 10/11/11, Yuri Dario <mc...@mclink.it> wrote:

> Hi Pedro,
> 
> 
> > I would also like to know the origin of the file to
> note it
> > in the NOTICE file.
> 
> I wrote this code. I think I used some other code as
> template, but now I don't recall the details
> (too many years...)
>

The problem is if the code doesn't carry a license it's
assumed the code is proprietary and we cannot take it.
I need a license from here:
http://www.apache.org/legal/resolved.html#category-a

I personally prefer a BSD license for my work because
I can't make any claims about patents but If the code
you used as a template is from OOo, then we
(actually you and only you) can add AL2 header on it.

See the Appendix here:
http://apache.org/licenses/LICENSE-2.0

Sorry that contributing is such a mess, but you learn
this stuff once and it works everywhere ;).

> 
> > ps. What compiler do you use for the OS/2 port?
> 
> the 3.2 build has been done with gcc 4.3.2, now I'm using
> gcc 4.4 (moving to 4.5)
> 

I had no idea EMX had continued advancing.. cool :).

> > I would welcome a binary OS/2 port for Dmake:
> > http://code.google.com/p/ooo-dmake/
> 
> I have it, at OOo 3.2 level, and it says to be a 4.12
> version, so  seems quite recent :-)
> 

There were some minor updates that were not included in
an old 4.12. I guess you will be making a new one so feel
free to send me a private message with a packaged version
or submit it as an issue in the google code place.

cheers,

Pedro.

> /*
>  * OS/2 open source software
>  * http://web.os2power.com/yuri
>  * http://www.netlabs.org
> */
>

ps. If Ted Tsikora is still around there, tell him
I said hi ;). 

Pedro.

Re: [patch} removal of OS2Bitmap.cxx

Posted by Yuri Dario <mc...@mclink.it>.
Hi Pedro,


> I would also like to know the origin of the file to note it
> in the NOTICE file.

I wrote this code. I think I used some other code as template, but now
I don't recall the details (too many years...)


> ps. What compiler do you use for the OS/2 port?

the 3.2 build has been done with gcc 4.3.2, now I'm using gcc 4.4 
(moving to 4.5)

> I would welcome a binary OS/2 port for Dmake:
> http://code.google.com/p/ooo-dmake/

I have it, at OOo 3.2 level, and it says to be a 4.12 version, so 
seems quite recent :-)


-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/



Re: [patch} removal of OS2Bitmap.cxx - OS2Bitmap.diff [1/1]

Posted by Yuri Dario <mc...@mclink.it>.
Hi Pedro,

attached the patch to OS2Bitmap.cxx, now aligned to the other os/2 
specific source code portions.

thanks,

-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/


Re: [patch} removal of OS2Bitmap.cxx

Posted by Pedro Giffuni <pf...@apache.org>.
Hi Yuri;

--- On Tue, 10/11/11, Yuri Dario <mc...@mclink.it> wrote:
...
> 
> > I will be glad to revert the commit once there
> > is a newly licensed OS2Bitmap.cxx available.
> 
> I don't have now an AOOo svn tree here, so I'm unable to
> prepare a  patch; but OS2Clipboard.cxx has a correct
> license header, you can grab it as is.
> 

The (lack-of) license header was the reason for it's removal.

Check the "Treatment of Third Party Works" section here:

http://www.apache.org/legal/src-headers.html

In particular number (2):
Do ensure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution.

I would also like to know the origin of the file to note it
in the NOTICE file.

best regards,

Pedro.

ps. What compiler do you use for the OS/2 port?

I would welcome a binary OS/2 port for Dmake:
http://code.google.com/p/ooo-dmake/


Re: [patch} removal of OS2Bitmap.cxx

Posted by Yuri Dario <mc...@mclink.it>.
Hi Pedro,

> Welcome Yuri!

thanks!

> I have great sympathy for the OS/2 port and I am glad you are
> working on it. 

great to ear, I will need some help around here :-))

> I will be glad to revert the commit once there
> is a newly licensed OS2Bitmap.cxx available.

I don't have now an AOOo svn tree here, so I'm unable to prepare a 
patch; but OS2Clipboard.cxx has a correct license header, you can grab
it as is.


-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/



Re: [patch} removal of OS2Bitmap.cxx

Posted by Pedro Giffuni <pf...@apache.org>.
Welcome Yuri!

--- On Mon, 10/10/11, Yuri Dario <mc...@mclink.it> wrote:

> Hi,
> 
> > Committed as revision 1179380, along with the odma
> header removal.
> 
> please revert this change, I'm going to work again on OOo
> OS/2 port and  I will change the license for OS2Bitmap.cxx
>

I have great sympathy for the OS/2 port and I am glad you are
working on it. I will be glad to revert the commit once there
is a newly licensed OS2Bitmap.cxx available.

Please note I did something similar with the odma.h header
already.

Pedro.

Re: [patch} removal of OS2Bitmap.cxx

Posted by Yuri Dario <mc...@mclink.it>.
Hi,

> Committed as revision 1179380, along with the odma header removal.

please revert this change, I'm going to work again on OOo OS/2 port 
and  I will change the license for OS2Bitmap.cxx

I hope to not be too late...

-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/



Re: [patch} removal of OS2Bitmap.cxx

Posted by Pedro Giffuni <pf...@apache.org>.
Committed as revision 1179380, along with the odma header removal.

Thanks!

Pedro.

--- On Wed, 10/5/11, Oliver-Rainer Wittmann <or...@googlemail.com> wrote:

> From: Oliver-Rainer Wittmann <or...@googlemail.com>
> Subject: [patch} removal of OS2Bitmap.cxx
> To: ooo-dev@incubator.apache.org
> Date: Wednesday, October 5, 2011, 9:18 AM
> Hi,
> 
> attached you find the patch to remove
> main/dtrans/source/os2/clipb/OS2Bitmap.cxx due to missing
> license header.
> 
> This file was only of relevance for OS2, if
> OOO_VENDOR=="Serenity Systems Intl"
> 
> Can someone please review the patch and commit it to the
> reprository.
> 
> Thanks in advance,
> Oliver.
>