You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Murali Reddy <mu...@gmail.com> on 2013/01/07 11:50:38 UTC
Re: Review Request: CLOUDSTACK-595 : Recreate root volume scenarios doesn't
work in vmware
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8432/#review15109
-----------------------------------------------------------
Ship it!
Ship It!
- Murali Reddy
On Dec. 8, 2012, 4:18 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8432/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2012, 4:18 p.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> Issue seen during system vm template upgrade and restoreVM command scenarios for vmware. In these cases CS tries to recreate root disk with same name as the existing one, in case of vmware this results in creation of vmdk file with same name for both existing and new root volume. This results in undesired behavior when storage cleanup thread tries to cleanup old volume. Made the vmdk file name unique by adding the volume id to it. This will ensure that during volume recreation in the scenarios mentioned vmdk will get created with a new name and there will be no undesired side effects of running the storage cleanup thread.
>
>
> This addresses bug CLOUDSTACK-595.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0b0f285
> server/src/com/cloud/storage/StorageManagerImpl.java e252633
>
> Diff: https://reviews.apache.org/r/8432/diff/
>
>
> Testing
> -------
>
> Enabled storage cleanup (check storage.cleanup.* global settings)
> Verified the following:
> - On the primary storage verify that root vmdk file is created with a name like ROOT-<vm_id>-<volume_id>.vmdk
> - After system vm template upgrade for vmware verified that the vm continues to run even after storage cleanup thread has executed. And the new vmdk file for root volume exists on primary storage
> - After running restoreVirtualMachine command verify that a new vmdk gets created.
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request: CLOUDSTACK-595 : Recreate root volume scenarios doesn't
work in vmware
Posted by Koushik Das <ko...@citrix.com>.
> On Jan. 7, 2013, 10:50 a.m., Murali Reddy wrote:
> > Ship It!
committed on master
commit 3ffbc4320abc9fd03ad3abd1f8077cc8d8f9ed4c
commit bf6ed9312d529f9c790622f06e9e2363b32339e8
also added to 4.0 branch
- Koushik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8432/#review15109
-----------------------------------------------------------
On Dec. 8, 2012, 4:18 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8432/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2012, 4:18 p.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> Issue seen during system vm template upgrade and restoreVM command scenarios for vmware. In these cases CS tries to recreate root disk with same name as the existing one, in case of vmware this results in creation of vmdk file with same name for both existing and new root volume. This results in undesired behavior when storage cleanup thread tries to cleanup old volume. Made the vmdk file name unique by adding the volume id to it. This will ensure that during volume recreation in the scenarios mentioned vmdk will get created with a new name and there will be no undesired side effects of running the storage cleanup thread.
>
>
> This addresses bug CLOUDSTACK-595.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0b0f285
> server/src/com/cloud/storage/StorageManagerImpl.java e252633
>
> Diff: https://reviews.apache.org/r/8432/diff/
>
>
> Testing
> -------
>
> Enabled storage cleanup (check storage.cleanup.* global settings)
> Verified the following:
> - On the primary storage verify that root vmdk file is created with a name like ROOT-<vm_id>-<volume_id>.vmdk
> - After system vm template upgrade for vmware verified that the vm continues to run even after storage cleanup thread has executed. And the new vmdk file for root volume exists on primary storage
> - After running restoreVirtualMachine command verify that a new vmdk gets created.
>
>
> Thanks,
>
> Koushik Das
>
>