You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2023/11/21 06:35:12 UTC
[PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
SzyWilliam opened a new pull request, #969:
URL: https://github.com/apache/ratis/pull/969
https://issues.apache.org/jira/browse/RATIS-1940.
See the result:
<img width="1226" alt="image" src="https://github.com/apache/ratis/assets/48054931/556e001b-8c84-48b5-8909-23e8a739d302">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on PR #969:
URL: https://github.com/apache/ratis/pull/969#issuecomment-1822136818
> BTW, we should have pull requests for merging to asf-site-source. Once the source has been merged, we may generate asf-site and push it without another PR.
Thanks for telling me the best-practice of asf-site! I was wondering before why we need both asf-site-source and asf-site and now I learned why. I'll update the asf-site-source and generate the website next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on PR #969:
URL: https://github.com/apache/ratis/pull/969#issuecomment-1822033459
@szetszwo Thanks for reviewing this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #969:
URL: https://github.com/apache/ratis/pull/969#discussion_r1401287835
##########
index.html:
##########
@@ -152,6 +152,17 @@ <h4>Pluggable raft log</h4>
Application can define the policies of how to write data and where it should be written easily.
</p>
</div>
+
+ <div class="col-md-6 col-sm-6 feature-item">
+ <span class="glyphicon glyphicon-dashboard" aria-hidden="true"></span>
+ <h4>Pluggable metrics</h4>
+ <p>Ratis provides a pluggable observation layer. By default, it uses dropwizard4. Users can provide their
Review Comment:
@SzyWilliam , thanks for working on this! Let's also mention `ratis-metrics-dropwizard3`.
```
By default (ratis-metrics-default), it uses the shaded Dropwizard 4 provided by ratis-thirdparty.
Another implementation can be found in ratis-metrics-dropwizard3.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #969:
URL: https://github.com/apache/ratis/pull/969#issuecomment-1822092574
Please also push the source. :)
BTW, we should have pull requests for merging to `asf-site-source`. Once the source has been merged, we may generate `asf-site` and push it without another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on code in PR #969:
URL: https://github.com/apache/ratis/pull/969#discussion_r1401411740
##########
index.html:
##########
@@ -152,6 +152,17 @@ <h4>Pluggable raft log</h4>
Application can define the policies of how to write data and where it should be written easily.
</p>
</div>
+
+ <div class="col-md-6 col-sm-6 feature-item">
+ <span class="glyphicon glyphicon-dashboard" aria-hidden="true"></span>
+ <h4>Pluggable metrics</h4>
+ <p>Ratis provides a pluggable observation layer. By default, it uses dropwizard4. Users can provide their
Review Comment:
Sure! Let me change the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1940. Add pluggable metrics description into project website [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam merged PR #969:
URL: https://github.com/apache/ratis/pull/969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org