You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by er...@apache.org on 2018/02/05 19:24:38 UTC
lucene-solr:master: LUCENE-8149: NRTCachingDirectory does not need to
preemptively delete segment files and generate exceptions
Repository: lucene-solr
Updated Branches:
refs/heads/master dd90bfbe8 -> 4bd49726c
LUCENE-8149: NRTCachingDirectory does not need to preemptively delete segment files and generate exceptions
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4bd49726
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4bd49726
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4bd49726
Branch: refs/heads/master
Commit: 4bd49726c1416a6146c9bbb86fdf4d7c2adc2b1c
Parents: dd90bfb
Author: Erick Erickson <er...@apache.org>
Authored: Mon Feb 5 11:08:13 2018 -0800
Committer: Erick Erickson <er...@apache.org>
Committed: Mon Feb 5 11:08:13 2018 -0800
----------------------------------------------------------------------
.../java/org/apache/lucene/store/NRTCachingDirectory.java | 10 ----------
solr/CHANGES.txt | 3 +++
2 files changed, 3 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4bd49726/lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java b/lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java
index c2b071b..696fafe 100644
--- a/lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java
+++ b/lucene/core/src/java/org/apache/lucene/store/NRTCachingDirectory.java
@@ -142,18 +142,8 @@ public class NRTCachingDirectory extends FilterDirectory implements Accountable
if (VERBOSE) {
System.out.println(" to cache");
}
- try {
- in.deleteFile(name);
- } catch (IOException ioe) {
- // This is fine: file may not exist
- }
return cache.createOutput(name, context);
} else {
- try {
- cache.deleteFile(name);
- } catch (IOException ioe) {
- // This is fine: file may not exist
- }
return in.createOutput(name, context);
}
}
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4bd49726/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 94d3588..487ee5f 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -192,6 +192,9 @@ Optimizations
* SOLR-11711: Fixed distributed processing of facet.field/facet.pivot sub requests to prevent requesting
unneccessary and excessive '0' count terms from each shard (Houston Putman via hossman)
+* LUCENE-8149: NRTCachingDirectory does not need to preemptively delete segment files and generate exceptions
+ (Erick Erickson)
+
Other Changes
----------------------