[GitHub] [hive] szlta commented on a change in pull request #1947: HIVE-24725: Collect top priority items from llap cache policy

[GitBox <gi...@apache.org>]

szlta commented on a change in pull request #1947:
URL: https://github.com/apache/hive/pull/1947#discussion_r571923784



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -4564,6 +4564,9 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "The meaning of this parameter is the inverse of the number of time ticks (cache\n" +
         " operations, currently) that cause the combined recency-frequency of a block in cache\n" +
         " to be halved."),
+    LLAP_LRFU_CUTOFF_PERCENTAGE("hive.llap.io.lrfu.cutoff.percentage", 0.10f,

Review comment:
       Naming here could make a connection with the API I think: I'm missing "hot buffers"
   Something like hive.llap.io.lrfu.hotbuffers.cutoff.percentage or hive.llap.io.lrfu.hotbuffers.percentage just so that we use similar terminology in conf name and code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org