You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2012/07/03 23:02:35 UTC
[jira] [Created] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Robert Kanter created OOZIE-901:
-----------------------------------
Summary: When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
Key: OOZIE-901
URL: https://issues.apache.org/jira/browse/OOZIE-901
Project: Oozie
Issue Type: Bug
Reporter: Robert Kanter
Assignee: Robert Kanter
Priority: Minor
If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-901:
--------------------------------
Attachment: OOZIE-901.patch
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406165#comment-13406165 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
The patch doesn't apply cleanly. Can you resubmit?
patch -p0 -i ../OOZIE-901-v2.patch
patching file core/src/main/java/org/apache/oozie/ErrorCode.java
patching file core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java
patching file core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java
Hunk #1 FAILED at 67.
1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java.rej
patching file core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java
Are you using --no-prefix with git diff?
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901-v2.patch, OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406227#comment-13406227 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
Thanks Robert..Committed to trunk
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-901-v2.patch, OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406113#comment-13406113 ]
Robert Kanter commented on OOZIE-901:
-------------------------------------
Should I just do that for this JIRA and upload a new patch?
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406116#comment-13406116 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
Yeah..I think we can sneak in this JIRA itself
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406084#comment-13406084 ]
Robert Kanter commented on OOZIE-901:
-------------------------------------
In most other places where Error 302 is used, it says something like "format is wrong for ______". So, perhaps something like "format is wrong for Configuration: invalid app path"?
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406183#comment-13406183 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
I did a clean checkout of the code.
I will make manual changes to ServletUtilities before committing.
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901-v2.patch, OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406057#comment-13406057 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
Patch looks good.. +1
Some comments not directly related to the patch:
Can the errorMessage in ServletUtilites.validateAppPath be improved? When the application paths are not specified correctly, it just says 'invalid parameter' which is confusing.
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-901:
--------------------------------
Attachment: OOZIE-901-v2.patch
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901-v2.patch, OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406174#comment-13406174 ]
Robert Kanter commented on OOZIE-901:
-------------------------------------
I used --no-prefix.
It looks like it's having a problem with ServletUtilities, where all I did was add an if statement and change an error message.
This is what my ServletUtilities.ValidateAppPath() method looks like before applying the patch:
{code}
protected static void ValidateAppPath(String wfPath, String coordPath, String bundlePath) throws XServletException {
int n = 0;
if (wfPath != null) {
n ++;
}
if (coordPath != null) {
n ++;
}
if (bundlePath != null) {
n ++;
}
if (n != 1) {
throw new XServletException(HttpServletResponse.SC_BAD_REQUEST, ErrorCode.E0302);
}
}
{code}
And this is what it looks like after:
{code}
protected static void ValidateAppPath(String wfPath, String coordPath, String bundlePath) throws XServletException {
int n = 0;
if (wfPath != null) {
n ++;
}
if (coordPath != null) {
n ++;
}
if (bundlePath != null) {
n ++;
}
if (n == 0) {
throw new XServletException(HttpServletResponse.SC_BAD_REQUEST, ErrorCode.E0302, "a workflow, coordinator, or bundle app path is required");
}
if (n != 1) {
throw new XServletException(HttpServletResponse.SC_BAD_REQUEST, ErrorCode.E0302, "Multiple app paths specified, only one is allowed");
}
}
{code}
Does your ServletUtilities.ValidateAppPath() look like my "before" version?
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901-v2.patch, OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-901) When Submitting a job without an app
path, Oozie doesn't properly handle multiple paths from oozie.libpath
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406109#comment-13406109 ]
Virag Kothari commented on OOZIE-901:
-------------------------------------
We can do something like
if (n==0)
throw 'one of wf, coord and bundle app path is required'
else if(n>1)
throw 'Multiple app path specified, only one allowed.
> When Submitting a job without an app path, Oozie doesn't properly handle multiple paths from oozie.libpath
> ----------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-901
> URL: https://issues.apache.org/jira/browse/OOZIE-901
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-901.patch
>
>
> If you submit a job without at least one of app path, coordinator app path, or bundle app path, Oozie will try to use oozie.libpath as the app path; but, it just tries to take the entire oozie.libpath, even if it contains multiple comma separated paths.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira