You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 11:47:25 UTC

[GitHub] [airflow] eladkal opened a new issue, #24826: Refactor/Review `EcsOperator`

eladkal opened a new issue, #24826:
URL: https://github.com/apache/airflow/issues/24826

   ### Body
   
   After reading https://stackoverflow.com/questions/72630480/airflow-sensor-for-aws-ecs-task I checked the source code as it should have been relativly easy to get the functionality user is requesting but discovered that [`EcsOperator`](https://github.com/apache/airflow/blob/ec6761a5c0d031221d53ce213c0e42813606c55d/airflow/providers/amazon/aws/operators/ecs.py#L168)
   seems like hook + operator + sensor in a single class which makes it harder to create a sensor as the user wishes.
   
   For some reason we don't have `EcsHook` ? I didn't find reason why we don't have one or why the operator handle so much logic on it's own.
   
   If we take for example:
   https://github.com/apache/airflow/blob/ec6761a5c0d031221d53ce213c0e42813606c55d/airflow/providers/amazon/aws/operators/ecs.py#L420
   This is a function that should be on hook so it will be easy to extand and reuse (if for example we want to create a Sensor).
   
   The task:
   Review the class and refactor what needs to be extract to `EcsHook`, maybe create also `EcsSensor` as part of the refactor?
   
   FYI @ferruzzi @o-nikolas @vincbeck 
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #24826: Refactor/Review `EcsOperator`

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #24826: Refactor/Review `EcsOperator`
URL: https://github.com/apache/airflow/issues/24826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org