You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/09/29 06:46:11 UTC
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #1033: apps/bttester: implement NRPA rotation
KKopyscinski opened a new pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033
As per CORE v5.3, Vol 3, Part C 10.7.1 NRPA should also rotate, same
as RPA is doing right now. For time beeing let's implement this in
tester application, before it's implemented in host.
This affects GAP/BROB/BCST/BV-04-C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r741941908
##########
File path: apps/bttester/src/gap.c
##########
@@ -248,6 +252,40 @@ static struct ble_gap_adv_params adv_params = {
.disc_mode = BLE_GAP_DISC_MODE_NON,
};
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static void rotate_nrpa_cb(struct os_event *ev)
+{
+ assert(ev != NULL);
Review comment:
this assert seems to be not needed. Otherwise looks good. Please remove it and feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
KKopyscinski merged pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
KKopyscinski merged pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r741941908
##########
File path: apps/bttester/src/gap.c
##########
@@ -248,6 +252,40 @@ static struct ble_gap_adv_params adv_params = {
.disc_mode = BLE_GAP_DISC_MODE_NON,
};
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static void rotate_nrpa_cb(struct os_event *ev)
+{
+ assert(ev != NULL);
Review comment:
this assert seems to be not needed. Otherwise looks good. Please remove it and feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r718515431
##########
File path: apps/bttester/src/gap.c
##########
@@ -63,6 +63,10 @@ static struct os_callout connected_ev_co;
static struct gap_device_connected_ev connected_ev;
#define CONNECTED_EV_DELAY_MS(itvl) 8 * BLE_HCI_CONN_ITVL * itvl / 1000
static int connection_attempts;
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static ble_npl_time_t advertising_start;
Review comment:
switched to os_time and fixed logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski merged pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
KKopyscinski merged pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r741941908
##########
File path: apps/bttester/src/gap.c
##########
@@ -248,6 +252,40 @@ static struct ble_gap_adv_params adv_params = {
.disc_mode = BLE_GAP_DISC_MODE_NON,
};
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static void rotate_nrpa_cb(struct os_event *ev)
+{
+ assert(ev != NULL);
Review comment:
this assert seems to be not needed. Otherwise looks good. Please remove it and feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r718515431
##########
File path: apps/bttester/src/gap.c
##########
@@ -63,6 +63,10 @@ static struct os_callout connected_ev_co;
static struct gap_device_connected_ev connected_ev;
#define CONNECTED_EV_DELAY_MS(itvl) 8 * BLE_HCI_CONN_ITVL * itvl / 1000
static int connection_attempts;
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static ble_npl_time_t advertising_start;
Review comment:
switched to os_time and fixed logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r718319873
##########
File path: apps/bttester/src/gap.c
##########
@@ -63,6 +63,10 @@ static struct os_callout connected_ev_co;
static struct gap_device_connected_ev connected_ev;
#define CONNECTED_EV_DELAY_MS(itvl) 8 * BLE_HCI_CONN_ITVL * itvl / 1000
static int connection_attempts;
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static ble_npl_time_t advertising_start;
Review comment:
bttester does not use npl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r718319873
##########
File path: apps/bttester/src/gap.c
##########
@@ -63,6 +63,10 @@ static struct os_callout connected_ev_co;
static struct gap_device_connected_ev connected_ev;
#define CONNECTED_EV_DELAY_MS(itvl) 8 * BLE_HCI_CONN_ITVL * itvl / 1000
static int connection_attempts;
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static ble_npl_time_t advertising_start;
Review comment:
bttester does not use npl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1033: apps/bttester: implement NRPA rotation
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r741941908
##########
File path: apps/bttester/src/gap.c
##########
@@ -248,6 +252,40 @@ static struct ble_gap_adv_params adv_params = {
.disc_mode = BLE_GAP_DISC_MODE_NON,
};
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static void rotate_nrpa_cb(struct os_event *ev)
+{
+ assert(ev != NULL);
Review comment:
this assert seems to be not needed. Otherwise looks good. Please remove it and feel free to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org