[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[swill <gi...@git.apache.org>]

Github user swill commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1444#discussion_r58316653
  
    --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java ---
    @@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock invocation) throws Throwab
             // IO traffic as generated by the logic above, must be greater than zero
             Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
             Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
    +        // Memory limit of VM must be greater than zero
    --- End diff --
    
    @maneesha-p: can you shed some light on this?
    
    > You specify that memory must be greater than zero in this comment, but it uses >= in the actual logic. Can you explain?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---