You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Facyla (via GitHub)" <gi...@apache.org> on 2026/03/12 18:38:08 UTC

Re: [PR] feat: add custom thresholds and colors to CountryMap plugin [superset]

Facyla commented on PR #36732:
URL: https://github.com/apache/superset/pull/36732#issuecomment-4049114033

   Hi, 
   Sorry for delayed reply.. i've had very few time to follow this PR recently and won't be able to write major changes to the feature. 
   While i find the UI better (let's say it: there's an UI instead of no UI) with your suggestions @SBIN2010, i think it's more adapted to specific custom minor changes, but less straight-forward to configure several maps with the same custom set of intervals/colors. In my use case, that feature would help setting up a specific custom rendering that could be quickly applied by copy/pasting a given config once defined. I envision visual config as an helper, rather as a replacement. 
   
   Preserving the best of the 2 approaches seems possible if we have any text-based config, whether json or any other structure (even line-by-line config such as #HEX:threshold:operator:gradient withonly the first 2 being required). 
   => If these visual setters end up in an text-based config that could also be editable all at once by the user, i'd go for it. In that case, defining and implementing that structure would be sufficient to avoid any non-blocking change afterwards, and releasing the feature would be possible without requiring a big rewrite.
   Would that be OK? 
   Florian


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org