[GitHub] [airflow] kaxil edited a comment on pull request #18722: Remove repetitive call to get executor class from config

[GitBox <gi...@apache.org>]

kaxil edited a comment on pull request #18722:
URL: https://github.com/apache/airflow/pull/18722#issuecomment-934659751


   > I dont think this change will bring that issue back as executor assignment logic remains the same and loading executor will be the still the same. The only difference executor_class will be fetched either from executor which is just after that arguments assignment in the IF. Otherwise, it will be looked up through property. Is there any test case that checks that scenario? Tests I run all passed.
   
   As soon as you do `self.executor_class = self.executor.__class__.__name__` (out of if statement) it needlessly loads the executor (check code block below) just to get the Class name. Please check detailed description in https://github.com/apache/airflow/pull/16700
   
   https://github.com/apache/airflow/blob/47f43ec7f32c1887f074ef2dbd88d27aa0c1d684/airflow/jobs/base_job.py#L112
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org