You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2013/07/22 06:59:27 UTC

svn commit: r1505596 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java

Author: liyin
Date: Mon Jul 22 04:59:26 2013
New Revision: 1505596

URL: http://svn.apache.org/r1505596
Log:
[HBASE-3855] A temporary fix to address reseek performace.

Author: shaneh

Summary:
This is a temporary fix that uses seek instead of reseek to address
a reseek performance issue while a more permenent reseek is being worked on.

Test Plan: Test in shadow

Reviewers: aaiyer

Reviewed By: aaiyer

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D889350

Task ID: 2491819

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java?rev=1505596&r1=1505595&r2=1505596&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java Mon Jul 22 04:59:26 2013
@@ -665,16 +665,8 @@ public class MemStore implements HeapSiz
 
     @Override
     public boolean reseek(KeyValue key) {
-      while (kvsetNextRow != null &&
-          comparator.compare(kvsetNextRow, key) < 0) {
-        kvsetNextRow = getNext(kvsetIt);
-      }
-
-      while (snapshotNextRow != null &&
-          comparator.compare(snapshotNextRow, key) < 0) {
-        snapshotNextRow = getNext(snapshotIt);
-      }
-      return (kvsetNextRow != null || snapshotNextRow != null);
+      //shaneh Jul-17-2013: Temporary fix while a more efficient reseek is worked on.
+      return seek(key);
     }
 
     public synchronized KeyValue peek() {