[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5686: xtensa/esp32s3: Add SPI RAM/PSRAM Support

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #5686:
URL: https://github.com/apache/incubator-nuttx/pull/5686#discussion_r821017452



##########
File path: arch/xtensa/src/esp32s3/esp32s3_allocateheap.c
##########
@@ -80,5 +83,11 @@ void up_allocate_heap(void **heap_start, size_t *heap_size)
 #if CONFIG_MM_REGIONS > 1
 void xtensa_add_region(void)
 {
+  void  *start;
+  size_t size;
+
+  start = (void *) SOC_EXTRAM_DATA_HIGH - g_psram_size;
+  size  = (size_t) g_psram_size;
+  umm_addregion(start, size);

Review comment:
       Heap management is out of scope on this PR, this change should be reverted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org