You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/10 08:13:50 UTC
[GitHub] [dolphinscheduler] JinyLeeChina opened a new issue #6772: [Improvement][API] API operation optimization
JinyLeeChina opened a new issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
### Dag API
1. Create offline workflows and schedules
2. Update workflow basic information
3. Update schedule information by process definition code
4. Online or offline workflow and schedule at the same time
5. Delete the workflow and schedule at the same time
6. Online is not allowed for empty workflow
### Task API
1. Specify the online or offline status when creating tasks
2. Online or downstream dependent tasks will not be deleted
3. Task online and offline interface
### Relation API
1. Add task to workflow
2. Remove task from workflow
3. Task moves from A workflow to B workflow
4. Task delete upstream dependency
5. Task add upstream dependency
### Execution API
1. Specify task execution interface
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yikeshiguang commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
yikeshiguang commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-991637521
收到。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964894157
Good job! I thinks this is a huge change, and we should add label `DSIP` on it, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description
-- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted.
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available.
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions.
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code
16 | Schedule | online | update | Empty workflow is not allowed to go online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SimpleGrey commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
SimpleGrey commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-971258562
I'll complete the “deleteProcessDefinitionVersion”(num 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description | status
-- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created | - [ ]
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online | - [ ]
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online | - [ ]
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted | - [ ]
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted. | - [ ]
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available. | - [ ]
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted | - [ ]
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies | - [ ]
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow | - [ ]
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions. | - [ ]
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency | - [ ]
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency | - [ ]
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency | - [ ]
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency | - [ ]
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code | - [ ]
16 | Schedule | online | update | Empty workflow is not allowed to go online. | - [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
status | num | Interface | Interface method | Operate | Function description
-- | -- | -- | -- | -- | --
- [ ] | 1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created
- [ ] | 2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online
- [ ] | 3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
- [ ] | 4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted
- [ ] | 5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted.
- [ ] | 6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available.
- [ ] | 7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted
- [ ] | 8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies
- [ ] | 9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow
- [ ] | 10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions.
- [ ] | 11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency
- [ ] | 12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency
- [ ] | 13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency
- [ ] | 14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency
- [ ] | 15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code
- [ ] | 16 | Schedule | online | update | Empty workflow is not allowed to go online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964900894
> Create offline workflows and schedules
Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
> Task delete upstream dependency
Task add upstream dependency
should we also add downstream for tasks? Oh, I see that in
> Online or downstream dependent tasks will not be deleted
why should we delete downstream tasks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yikeshiguang commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
yikeshiguang commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-971212509
I'll complete the releaseTaskDefinition interface!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description | status
-- | -- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created | - [X]
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online | - [ ]
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online | - [ ]
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted | - [ ]
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted. | - [ ]
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available. | - [ ]
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted | - [ ]
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies | - [ ]
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow | - [ ]
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions. | - [ ]
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency | - [ ]
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency | - [ ]
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency | - [ ]
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency | - [ ]
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code | - [ ]
16 | Schedule | online | update | Empty workflow is not allowed to go online. | - [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964968558
>>> Create offline workflows and schedules
>>
>>Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
It create a empty offline workeflow. I think one dag should have schedule.
>> >Task delete upstream dependency
>>> Task add upstream dependency
>>
>>should we also add downstream for tasks? Oh, I see that in
>>
>>> Online or downstream dependent tasks will not be deleted
>>
>>why should we delete downstream tasks?
You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] edward-yang commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
edward-yang commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-971217555
I will implement interface "createEmptyProcessDefinition" and "updateProcessDefinitionBasicInfo"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina removed a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina removed a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964971129
> > > > Create offline workflows and schedules
> > >
> > >
> > > Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
>
> It create a empty offline workeflow. I think one dag should have schedule.
>
> > > > Task delete upstream dependency
> > > > Task add upstream dependency
> > >
> > >
> > > should we also add downstream for tasks? Oh, I see that in
> > > > Online or downstream dependent tasks will not be deleted
> > >
> > >
> > > why should we delete downstream tasks?
>
> You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964880936
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yikeshiguang commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
yikeshiguang commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-991637521
收到。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo closed issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
lenboo closed issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description
-- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted.
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions.
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code
16 | Schedule | online | update | Empty workflow is not allowed to go online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
status | num | Interface | Interface method | Operate | Function description
-- | -- | -- | -- | -- | --
- [ ] | 1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created
- [ ] | 2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online
- [ ] | 3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
- [ ] | 4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted
- [ ] | 5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted.
- [ ] | 6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available.
- [ ] | 7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted
- [ ] | 8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies
- [ ] | 9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow
- [ ] | 10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions.
- [ ] | 11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency
- [ ] | 12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency
- [ ] | 13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency
- [ ] | 14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency
- [ ] | 15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code
- [ ] | 16 | Schedule | online | update | Empty workflow is not allowed to go online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description | status
-- | -- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created | - [ ]
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online | - [ ]
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online | - [ ]
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted | - [ ]
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted. | - [ ]
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available. | - [ ]
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted | - [ ]
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies | - [ ]
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow | - [ ]
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions. | - [ ]
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency | - [ ]
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency | - [ ]
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency | - [ ]
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency | - [ ]
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code | - [ ]
16 | Schedule | online | update | Empty workflow is not allowed to go online. | - [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-975021612
fix swagger view at #6933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964894157
I thinks this is a huge change, and we should add label `DSIP` on it, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina closed issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina closed issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964900778
Can you add the background explanation of why to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964968558
> >> Create offline workflows and schedules
> >
> >Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
It create a empty offline workeflow. I think one dag should have schedule.
> > >Task delete upstream dependency
> >> Task add upstream dependency
> >
> >should we also add downstream for tasks? Oh, I see that in
> >
> >> Online or downstream dependent tasks will not be deleted
>>
> >why should we delete downstream tasks?
You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964968558
> > Create offline workflows and schedules
>
> Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
It create a empty offline workeflow. I think one dag should have schedule.
> > Task delete upstream dependency
> > Task add upstream dependency
>
> should we also add downstream for tasks? Oh, I see that in
>
> > Online or downstream dependent tasks will not be deleted
>
> why should we delete downstream tasks?
You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo closed issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
lenboo closed issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964968558
>> Create offline workflows and schedules
>
>Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
It create a empty offline workeflow. I think one dag should have schedule.
>>Task delete upstream dependency
>> Task add upstream dependency
>
>should we also add downstream for tasks? Oh, I see that in
>
>> Online or downstream dependent tasks will not be deleted
>
>why should we delete downstream tasks?
You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-964971129
> > > > Create offline workflows and schedules
> > >
> > >
> > > Sometime we only need to create workflow without schedule, do you think we should support it or not? I thinks the schedule just an additions informations to workflow, mean that url would look like `/workflow/<workflow_code>/schedule`
>
> It create a empty offline workeflow. I think one dag should have schedule.
>
> > > > Task delete upstream dependency
> > > > Task add upstream dependency
> > >
> > >
> > > should we also add downstream for tasks? Oh, I see that in
> > > > Online or downstream dependent tasks will not be deleted
> > >
> > >
> > > why should we delete downstream tasks?
>
> You're right, here we can support add/delete downstream tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #6772: [Improvement][API] API operation optimization
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #6772:
URL: https://github.com/apache/dolphinscheduler/issues/6772#issuecomment-969828971
num | Interface | Interface method | Operate | Function description
-- | -- | -- | -- | --
1 | ProcessDefinition | createEmptyProcessDefinition | new | Create offline empty workflow and schedule at the same time. When schedulejson is empty, only empty work will be created
2 | ProcessDefinition | updateProcessDefinitionBasicInfo | new | Modify the basic information of workflow and schedule. When schedulejson is empty, only the basic information of workflow can be modified, or the online status can be specified. An empty workflow is not allowed to go online
3 | ProcessDefinition | releaseWorkflowAndSchedule | new | At the same time, online and offline workflows and scheduled workflows are not allowed. Empty workflows are not allowed to go online
4 | ProcessDefinition | deleteWorkflowAndSchedule | new | Workflow and timing can be deleted at the same time. Only offline workflow and timing can be deleted
5 | ProcessDefinition | deleteProcessDefinitionVersion | new | The workflow of the main table version is not allowed to be deleted.
6 | TaskDefinition | releaseTaskDefinition | new | The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available.
7 | TaskDefinition | deleteTaskDefinitionVersion | update | The task of master table version cannot be deleted
8 | ProcessTaskRelation | createProcessTaskRelation | new | Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies
9 | ProcessTaskRelation | moveTaskProcessRelation | new | The task switches the workflow, and judges that the dependency and subprocess cannot be added to their own workflow
10 | ProcessTaskRelation | deleteTaskProcessRelation | new | Tasks are removed from the workflow and deleted directly when tasks are dependence, subProcess and conditions.
11 | ProcessTaskRelation | deleteUpstreamRelation | new | Task delete upstream dependency
12 | ProcessTaskRelation | deleteDownstreamRelation | new | Task delete downstream dependency
13 | ProcessTaskRelation | queryUpstreamRelation | new | Task query upstream dependency
14 | ProcessTaskRelation | queryDownstreamRelation | new | Task query downstream dependency
15 | Schedule | updateScheduleByProcessDefinitionCode | new | Modify schedule according to workflow code
16 | Schedule | online | update | Empty workflow is not allowed to go online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org