[GitHub] [iceberg] boroknagyz edited a comment on pull request #3947: Hive: HiveSchemaConverter should use one-based indexing like Iceberg …

[GitBox <gi...@apache.org>]

boroknagyz edited a comment on pull request #3947:
URL: https://github.com/apache/iceberg/pull/3947#issuecomment-1019872087


   Another thing is that you can create a partitioned Iceberg table in Hive by setting the table property 'iceberg.mr.table.partition.spec':
   https://github.com/apache/hive/blob/392c4f259ad57d746280790a21e560319ace4c8d/iceberg/iceberg-handler/src/test/queries/positive/describe_iceberg_table.q#L11
   
   To define this property, the user has to be aware of details of the Iceberg specification, i.e. field ids, source ids, and so on. Without this change the user would need to use different ids than the ids assigned by Iceberg later, which I think can be very confusing.
   
   We don't have the corresponding tests here I think, but in the Hive repo some tests would fail if Iceberg starts to use different field id assignment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org