You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by khudalla <Ka...@de.bosch.com> on 2008/06/02 08:50:54 UTC
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Rob,
I see what you mean. I think that the "ClientInternalExceptionListener"
should not be limited to JMSExceptions though, i.e. it should not implement
javax.jms.ExceptionListener but instead an interface
that provides an onException(Throwable exception) method, do you agree?
If so, I will add this to ActiveMQConnection and send you a patch for
review, okay?
Kai
rajdavies wrote:
>
> Hi Kai,
>
> I think you missed understood :)
> I'm proposing to add another on method on Connection - e.g.
> setClientInternalExceptionListener() - that registers an exception
> listener of internal exceptions only - like in this
> ActiveMQSession.run() case.
>
> We then only pass exceptions to the ExceptionListener registered by
> setExceptionListener() that directly affect the connection.
>
> cheers,
>
> Rob
>
--
View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17595013.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Posted by khudalla <Ka...@de.bosch.com>.
Done!
I actually tried to do that when uploading the patch initially. However, the
checkbox was not available then. It is only available when attaching a file
after the issue has been created ...
Kai
rajdavies wrote:
>
> Kai - can you re-add the patch and click the grant ASF licence option?
> On 2 Jun 2008, at 16:06, khudalla wrote:
>
>
--
View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17616968.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Posted by Rob Davies <ra...@gmail.com>.
Kai - can you re-add the patch and click the grant ASF licence option?
On 2 Jun 2008, at 16:06, khudalla wrote:
>
> Rob,
>
> I have created JIRA issue AMQ-1760 and attached a patch implementing
> the
> functionality we have been talking about.
> Would you please take a look at it?
>
> Regards,
> Kai
>
>
> rajdavies wrote:
>>
>> Sounds good - please send a patch!
>>
>>
>
> --
> View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17603539.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Posted by Rob Davies <ra...@gmail.com>.
Great thx Kai!
On 2 Jun 2008, at 16:06, khudalla wrote:
>
> Rob,
>
> I have created JIRA issue AMQ-1760 and attached a patch implementing
> the
> functionality we have been talking about.
> Would you please take a look at it?
>
> Regards,
> Kai
>
>
> rajdavies wrote:
>>
>> Sounds good - please send a patch!
>>
>>
>
> --
> View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17603539.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Posted by khudalla <Ka...@de.bosch.com>.
Rob,
I have created JIRA issue AMQ-1760 and attached a patch implementing the
functionality we have been talking about.
Would you please take a look at it?
Regards,
Kai
rajdavies wrote:
>
> Sounds good - please send a patch!
>
>
--
View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17603539.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: Handling of RuntimeExceptions in ActiveMQSession.run() method
Posted by Rob Davies <ra...@gmail.com>.
Sounds good - please send a patch!
On 2 Jun 2008, at 07:50, khudalla wrote:
>
> Rob,
>
> I see what you mean. I think that the
> "ClientInternalExceptionListener"
> should not be limited to JMSExceptions though, i.e. it should not
> implement
> javax.jms.ExceptionListener but instead an interface
> that provides an onException(Throwable exception) method, do you
> agree?
>
> If so, I will add this to ActiveMQConnection and send you a patch for
> review, okay?
>
> Kai
>
>
> rajdavies wrote:
>>
>> Hi Kai,
>>
>> I think you missed understood :)
>> I'm proposing to add another on method on Connection - e.g.
>> setClientInternalExceptionListener() - that registers an exception
>> listener of internal exceptions only - like in this
>> ActiveMQSession.run() case.
>>
>> We then only pass exceptions to the ExceptionListener registered by
>> setExceptionListener() that directly affect the connection.
>>
>> cheers,
>>
>> Rob
>>
>
> --
> View this message in context: http://www.nabble.com/Handling-of-RuntimeExceptions-in-ActiveMQSession.run%28%29-method-tp17554360s2354p17595013.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>