You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/30 00:15:59 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7350:
Refactor out controlUtils.js module + unit tests
codecov-io edited a comment on issue #7350: Refactor out controlUtils.js module + unit tests
URL: https://github.com/apache/incubator-superset/pull/7350#issuecomment-486362137
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=h1) Report
> Merging [#7350](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4fe152d1560764527c6d8eca19bc91f344c63e5e?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `96.51%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7350/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7350 +/- ##
==========================================
+ Coverage 64.89% 65.05% +0.16%
==========================================
Files 428 429 +1
Lines 20979 20993 +14
Branches 2337 2331 -6
==========================================
+ Hits 13615 13658 +43
+ Misses 7240 7219 -21
+ Partials 124 116 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set/assets/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2dldEluaXRpYWxTdGF0ZS5qcw==) | `90.9% <ø> (ø)` | :arrow_up: |
| [...ts/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZVZpZXdDb250YWluZXIuanN4) | `31.91% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `31.57% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3N0b3JlLmpz) | `93.75% <100%> (+29.38%)` | :arrow_up: |
| [superset/assets/src/visualizations/deckgl/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvdXRpbHMuanM=) | `92.85% <50%> (-1.59%)` | :arrow_down: |
| [superset/assets/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xVdGlscy5qcw==) | `97.01% <97.01%> (ø)` | |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.85% <0%> (+0.79%)` | :arrow_up: |
| [superset/assets/src/explore/validators.js](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3ZhbGlkYXRvcnMuanM=) | `68.75% <0%> (+6.25%)` | :arrow_up: |
| [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/7350/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `87.5% <0%> (+12.5%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=footer). Last update [4fe152d...ae4a5c1](https://codecov.io/gh/apache/incubator-superset/pull/7350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org