You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/02/21 01:48:50 UTC
[GitHub] cordova-lib pull request #519: CB-11346 - Remove known platforms check for P...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/519
CB-11346 - Remove known platforms check for Platform API
### Platforms affected
CLI
### What does this PR do?
Removes platforms check. Right now only known platforms are installable.
### What testing has been done on this change?
None. Unit tests are coming.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11346
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #519
----
commit 3effebb17fc3209ab78a503bf0ca793d7a853af6
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-02-21T01:47:14Z
CB-11346 - Remove known platforms check for Platform API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
This pr does address part of the issue, I think we can move ahead with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/519
re: https://issues.apache.org/jira/browse/CB-11346?focusedCommentId=15875577&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875577
Looks like there is more to it than the patch. The error occurs here: https://github.com/apache/cordova-lib/blob/a9605411ab007d700849c971043f0c211c06100c/cordova-lib/src/cordova/platform.js#L389
All three conditions have to be satisfied:
1. version (from package.json)
2. platform name (from package.json name, has to be in the form of cordova-XXXX where XXX is the actual platform name)
3. platform name exists in platformConfig.json file
We would have to remove checks 2 and 3, but not sure of the impact since platformConfig.json contains information that is probably needed elsewhere (ideally it would exist in the platform itself!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
We should ultimately just be checking that there is a valid platformAPI,
and if so, use it, otherwise fail.
( super simplification )
@purplecabbage
risingj.com
On Tue, Feb 21, 2017 at 4:19 PM, Jesse <pu...@gmail.com> wrote:
> Yeah, it's deep. If a platform does not have a known name, there will be
> issues currently.
> The only way right now is to fork a blessed platform, but there is no way
> to easily create your own with a generic name.
>
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Feb 21, 2017 at 4:16 PM, Shazron Abdullah <
> notifications@github.com> wrote:
>
>> The src/platforms/platforms.js file touches almost all commands,
>> particularly the use of the getPlatformAPI call, so removing this is
>> tricky -- but at least there is only one API call to abstract away.
>>
>> \u2014
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/cordova-lib/pull/519#issuecomment-281525835>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AAC0NikI4Tm7AIyhXZB6Ke6Mt6i0-tDFks5re35ngaJpZM4MGyTP>
>> .
>>
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/519
The `src/platforms/platforms.js` file touches almost all commands, particularly the use of the `getPlatformAPI` call, so removing this is tricky -- but at least there is only one API call to abstract away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
I've started a discuss thread on this subject.
https://github.com/cordova/cordova-discuss/issues/64
@purplecabbage
risingj.com
On Tue, Feb 21, 2017 at 4:20 PM, Jesse <pu...@gmail.com> wrote:
> We should ultimately just be checking that there is a valid platformAPI,
> and if so, use it, otherwise fail.
> ( super simplification )
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Feb 21, 2017 at 4:19 PM, Jesse <pu...@gmail.com> wrote:
>
>> Yeah, it's deep. If a platform does not have a known name, there will be
>> issues currently.
>> The only way right now is to fork a blessed platform, but there is no way
>> to easily create your own with a generic name.
>>
>>
>>
>> @purplecabbage
>> risingj.com
>>
>> On Tue, Feb 21, 2017 at 4:16 PM, Shazron Abdullah <
>> notifications@github.com> wrote:
>>
>>> The src/platforms/platforms.js file touches almost all commands,
>>> particularly the use of the getPlatformAPI call, so removing this is
>>> tricky -- but at least there is only one API call to abstract away.
>>>
>>> \u2014
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/cordova-lib/pull/519#issuecomment-281525835>,
>>> or mute the thread
>>> <https://github.com/notifications/unsubscribe-auth/AAC0NikI4Tm7AIyhXZB6Ke6Mt6i0-tDFks5re35ngaJpZM4MGyTP>
>>> .
>>>
>>
>>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #519: CB-11346 - Remove known platforms check for Platform...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
Yeah, it's deep. If a platform does not have a known name, there will be
issues currently.
The only way right now is to fork a blessed platform, but there is no way
to easily create your own with a generic name.
@purplecabbage
risingj.com
On Tue, Feb 21, 2017 at 4:16 PM, Shazron Abdullah <no...@github.com>
wrote:
> The src/platforms/platforms.js file touches almost all commands,
> particularly the use of the getPlatformAPI call, so removing this is
> tricky -- but at least there is only one API call to abstract away.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-lib/pull/519#issuecomment-281525835>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAC0NikI4Tm7AIyhXZB6Ke6Mt6i0-tDFks5re35ngaJpZM4MGyTP>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #519: CB-11346 - Remove known platforms check for P...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org