You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2019/08/01 16:35:10 UTC
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13979
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
IMPALA-8806: Add metrics to improve observability of executor groups
This patch adds 3 metrics under a new metric group called
"cluster-membership" that keep track of the number of executor groups
that have atleast one live executor, number of executor groups that are
in a healthy state and the number of backends registered with the
statestore.
Testing:
Modified tests to use these metrics for verification.
Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler-test-util.cc
M common/thrift/metrics.json
M tests/custom_cluster/test_auto_scaling.py
M tests/custom_cluster/test_executor_groups.py
8 files changed, 166 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/13979/1
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr-test.cc
File be/src/scheduling/cluster-membership-mgr-test.cc:
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr-test.cc@271
PS1, Line 271: MetricGroup tmp_metrics1("test-metrics1");
> We should create a dummy metrics group here instead of adding extra logic i
Done
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr.cc@48
PS1, Line 48: static const string LIVE_EXEC_GROUP_KEY("cluster-membership.executor-groups.total");
> Related to another comment, we could maybe omit the "live" adjective, since
Done
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json
File common/thrift/metrics.json:
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json@2446
PS1, Line 2446: exe
> It might be better to avoid introducing the new "live" terminology and simp
Done
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json@2446
PS1, Line 2446: at leas
> "at least" - here and below
Done
http://gerrit.cloudera.org:8080/#/c/13979/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/13979/1/tests/custom_cluster/test_executor_groups.py@43
PS1, Line 43: self.num_executors = 1
> I have a change that should be setting it to 50ms across all custom cluster
Done
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 18:55:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Lars Volker, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13979
to look at the new patch set (#4).
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
IMPALA-8806: Add metrics to improve observability of executor groups
This patch adds 3 metrics under a new metric group called
"cluster-membership" that keep track of the number of executor groups
that have at least one live executor, number of executor groups that are
in a healthy state and the number of backends registered with the
statestore.
Testing:
Modified tests to use these metrics for verification.
Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/service/impala-server.cc
M common/thrift/metrics.json
M tests/custom_cluster/test_auto_scaling.py
M tests/custom_cluster/test_executor_groups.py
9 files changed, 177 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/13979/4
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 1:
(5 comments)
Some minor comments, I think this will be very useful.
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr-test.cc
File be/src/scheduling/cluster-membership-mgr-test.cc:
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr-test.cc@271
PS1, Line 271: ClusterMembershipMgr cmm1(b1->address.hostname, nullptr, nullptr);
We should create a dummy metrics group here instead of adding extra logic in the product code.
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/13979/1/be/src/scheduling/cluster-membership-mgr.cc@48
PS1, Line 48: static const string LIVE_EXEC_GROUP_KEY("cluster-membership.executor-groups.total-live");
Related to another comment, we could maybe omit the "live" adjective, since I think it's intuitive that metrics shouldn't include "dead" groups, whatever that is.
I'm not that set on this, but I can imagine people asking "what does live mean?". Maybe others disagree, not too concerned about this.
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json
File common/thrift/metrics.json:
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json@2446
PS1, Line 2446: atleast
"at least" - here and below
http://gerrit.cloudera.org:8080/#/c/13979/1/common/thrift/metrics.json@2446
PS1, Line 2446: live
It might be better to avoid introducing the new "live" terminology and simply omit the adjective.
http://gerrit.cloudera.org:8080/#/c/13979/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/13979/1/tests/custom_cluster/test_executor_groups.py@43
PS1, Line 43: existing_ss_args = method.func_dict.get("state_store_args", "")
I have a change that should be setting it to 50ms across all custom cluster tests, so we could remove this (200ms is actually slower) - https://gerrit.cloudera.org/#/c/13967/5/tests/common/custom_cluster_test_suite.py
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:10:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 02:33:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 21:37:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Lars Volker, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13979
to look at the new patch set (#3).
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
IMPALA-8806: Add metrics to improve observability of executor groups
This patch adds 3 metrics under a new metric group called
"cluster-membership" that keep track of the number of executor groups
that have atleast one live executor, number of executor groups that are
in a healthy state and the number of backends registered with the
statestore.
Testing:
Modified tests to use these metrics for verification.
Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/service/impala-server.cc
M common/thrift/metrics.json
M tests/custom_cluster/test_auto_scaling.py
M tests/custom_cluster/test_executor_groups.py
9 files changed, 177 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/13979/3
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Only giving +1 as it does not compile but LGTM and we need this very soon :-)
http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG@11
PS2, Line 11: that have atleast one live executor, number of executor groups that are
typo -> at least
http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json
File common/thrift/metrics.json:
http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json@2456
PS2, Line 2456: "description": "Total number of executor groups that are in a healthy state",
I found the difference between "at least one executor" and "healthy" a bit confusing, could we add text somewhere to explain healthy means having at least the configured minimum number of executors. It also may be worth noting somewhere that cluster-membership.executor-groups.total >= cluster-membership.executor-groups.total-healthy
http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py@70
PS2, Line 70: assert any(self._get_num_backends() >= GROUP_SIZE + 1 or sleep(1)
The change here is because previously we were fetching number of executors, now we are fetching number of backends? So the +1 is because we have 1 coordinator? Might be worth a comment somewhere. Is there a metric for number of coordinators? [but don't delay this change adding this :-) ]
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 04 Aug 2019 19:39:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 21:41:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG@11
PS2, Line 11: that have at least one live executor, number of executor groups that are
> typo -> at least
Done
http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json
File common/thrift/metrics.json:
http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json@2456
PS2, Line 2456: "description": "Total number of executor groups that are in a healthy state, that is, have at least the configured minimum number of executors to be considered for admission",
> I found the difference between "at least one executor" and "healthy" a bit
Done. Also added a dcheck for cluster-membership.executor-groups.total >= cluster-membership.executor-groups.total-healthy.
http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py@70
PS2, Line 70: cluster_size = GROUP_SIZE + 1 # +1 to include coordinator.
> The change here is because previously we were fetching number of executors,
Yes the +1 is because we are also counting the coordinator.
There is currently no metric for the num of coordinators, if you think it will be useful we can add it in a separate patch like you suggested.
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 20:13:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
IMPALA-8806: Add metrics to improve observability of executor groups
This patch adds 3 metrics under a new metric group called
"cluster-membership" that keep track of the number of executor groups
that have at least one live executor, number of executor groups that are
in a healthy state and the number of backends registered with the
statestore.
Testing:
Modified tests to use these metrics for verification.
Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Reviewed-on: http://gerrit.cloudera.org:8080/13979
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/service/impala-server.cc
M common/thrift/metrics.json
M tests/custom_cluster/test_auto_scaling.py
M tests/custom_cluster/test_executor_groups.py
9 files changed, 177 insertions(+), 48 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 6
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4119/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 19:34:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Lars Volker, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13979
to look at the new patch set (#2).
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
IMPALA-8806: Add metrics to improve observability of executor groups
This patch adds 3 metrics under a new metric group called
"cluster-membership" that keep track of the number of executor groups
that have atleast one live executor, number of executor groups that are
in a healthy state and the number of backends registered with the
statestore.
Testing:
Modified tests to use these metrics for verification.
Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler-test-util.cc
M common/thrift/metrics.json
M tests/custom_cluster/test_auto_scaling.py
M tests/custom_cluster/test_executor_groups.py
8 files changed, 159 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/13979/2
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 20:24:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4117/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:13:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4140/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 20:29:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4732/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9
Gerrit-Change-Number: 13979
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 21:41:37 +0000
Gerrit-HasComments: No