You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by galen-pivotal <gi...@git.apache.org> on 2017/01/20 18:34:06 UTC

[GitHub] geode pull request #349: [GEODE-2324] fixes to AcceptorImpl.close()

GitHub user galen-pivotal opened a pull request:

    https://github.com/apache/geode/pull/349

    [GEODE-2324] fixes to AcceptorImpl.close()

    If the thread is interrupted during closing, just continue to shut down
    what we can.
    
    * Catch InterruptedException so cleanup continues.
    * Remove top-level exception handler to avoid masking exceptions that
    * could short-circuit shutdown.
    * Fix a synchronization bug that could cause AcceptorImpl to try to shut
      down twice.
    * Fix what looks like a bug where if closing the socket throws an
      IOException, we fail to shut anything else down, though we still have
      ourselves marked as shut down.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/galen-pivotal/incubator-geode feature/GEODE-2324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit 26f70874102bad830f81b36d496c6469103f2e74
Author: Galen O'Sullivan <go...@pivotal.io>
Date:   2017-01-18T23:00:47Z

    [GEODE-2324] fixes to AcceptorImpl.close()
    
    If the thread is interrupted during closing, just continue to shut down
    what we can.
    
    * Catch InterruptedException so cleanup continues.
    * Remove top-level exception handler to avoid masking exceptions that
    * could short-circuit shutdown.
    * Fix a synchronization bug that could cause AcceptorImpl to try to shut
      down twice.
    * Fix what looks like a bug where if closing the socket throws an
      IOException, we fail to shut anything else down, though we still have
      ourselves marked as shut down.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #349: [GEODE-2324] fixes to AcceptorImpl.close()

Posted by galen-pivotal <gi...@git.apache.org>.
Github user galen-pivotal closed the pull request at:

    https://github.com/apache/geode/pull/349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #349: [GEODE-2324] fixes to AcceptorImpl.close()

Posted by galen-pivotal <gi...@git.apache.org>.
Github user galen-pivotal commented on the issue:

    https://github.com/apache/geode/pull/349
  
    merged in cd2291102744f4bb1b8bb5170e7388b31295ef6f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---